Page MenuHomeFreeBSD

Use -fPIC on all arches; lua builds the object files into a shared lib.
ClosedPublic

Authored by ian on Feb 20 2016, 3:49 AM.
Tags
None
Referenced Files
F103812135: D5362.diff
Fri, Nov 29, 6:32 PM
Unknown Object (File)
Fri, Nov 22, 5:03 PM
Unknown Object (File)
Thu, Nov 14, 4:22 AM
Unknown Object (File)
Sat, Nov 9, 10:37 PM
Unknown Object (File)
Fri, Nov 1, 4:23 AM
Unknown Object (File)
Oct 23 2024, 3:35 PM
Unknown Object (File)
Oct 12 2024, 10:52 AM
Unknown Object (File)
Oct 12 2024, 10:49 AM
Subscribers
None

Details

Summary

Since the object files get built into a shared lib, using -fPIC on all arches is the right thing to do, instead of adding it to each new arch that comes along which doesn't accidentally allow non-PIC modules in shared libs.

This fixes PR 207324

Test Plan

Build- and run-tested on i386, amd64, arm, armv6.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ian retitled this revision from to Use -fPIC on all arches; lua builds the object files into a shared lib..
ian updated this object.
ian edited the test plan for this revision. (Show Details)
ian added reviewers: mat, sbruno.
ian set the repository for this revision to rP FreeBSD ports repository.
mat edited edge metadata.
This revision is now accepted and ready to land.Feb 20 2016, 10:29 AM
This revision was automatically updated to reflect the committed changes.