Page MenuHomeFreeBSD

atan2.3: Simplify asterisks
Needs ReviewPublic

Authored by ziaee on Thu, Nov 6, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 9, 12:52 AM
Restricted File
Sat, Nov 8, 8:33 PM
Unknown Object (File)
Fri, Nov 7, 12:11 PM
Unknown Object (File)
Fri, Nov 7, 12:10 PM
Unknown Object (File)
Fri, Nov 7, 9:19 AM
Unknown Object (File)
Fri, Nov 7, 6:52 AM
Unknown Object (File)
Fri, Nov 7, 4:11 AM
Unknown Object (File)
Fri, Nov 7, 3:50 AM
Subscribers

Details

Reviewers
dclarke_blastwave.org
Group Reviewers
manpages
Summary

Switch asterisk from a (pre ascii) low level roff escape to a normal
ascii asterisk character matching $otherOS. The old roff escape doesn't
render anywhere.

PR: 268421

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68465
Build 65348: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Thu, Nov 6, 7:43 PM

Just a few notes given that I don't know significance of one asterisk form over the other:

  1. NetBSD did not remove/replace the \(** macros, they are still there, e.g. https://github.com/NetBSD/src/blob/62c785e59d064070166dab5d2a4492055effba89/lib/libm/man/atan2.3#L150
  2. \(** renders just fine for me and is different from the simple ASCII asterisk so I find the "The old roff escape doesn't render anywhere" assertion doubtful.
  3. This mathematical asterisk is found in other man pages, and this man page has other mathematical UTF-8 symbols.

I tested it on 14.2, and the man page has render issues without this patch, see attached screenshot.{F135333051}