Page MenuHomeFreeBSD

atan2.3: Simplify asterisks
Needs ReviewPublic

Authored by ziaee on Thu, Nov 6, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 6:11 PM
Unknown Object (File)
Sun, Nov 30, 6:07 PM
Unknown Object (File)
Thu, Nov 27, 2:06 PM
Unknown Object (File)
Sat, Nov 22, 8:40 AM
Unknown Object (File)
Fri, Nov 21, 3:15 PM
Unknown Object (File)
Tue, Nov 18, 4:23 PM
Unknown Object (File)
Mon, Nov 17, 3:54 PM
Unknown Object (File)
Sun, Nov 16, 8:49 PM
Subscribers

Details

Reviewers
dclarke_blastwave.org
Group Reviewers
manpages
Summary

Switch asterisk from a (pre ascii) low level roff escape to a normal
ascii asterisk character matching $otherOS. The old roff escape doesn't
render anywhere.

PR: 268421

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68465
Build 65348: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Thu, Nov 6, 7:43 PM

Just a few notes given that I don't know significance of one asterisk form over the other:

  1. NetBSD did not remove/replace the \(** macros, they are still there, e.g. https://github.com/NetBSD/src/blob/62c785e59d064070166dab5d2a4492055effba89/lib/libm/man/atan2.3#L150
  2. \(** renders just fine for me and is different from the simple ASCII asterisk so I find the "The old roff escape doesn't render anywhere" assertion doubtful.
  3. This mathematical asterisk is found in other man pages, and this man page has other mathematical UTF-8 symbols.

I tested it on 14.2, and the man page has render issues without this patch, see attached screenshot.{F135333051}

Just a few notes given that I don't know significance of one asterisk form over the other:

  1. NetBSD did not remove/replace the \(** macros, they are still there, e.g. https://github.com/NetBSD/src/blob/62c785e59d064070166dab5d2a4492055effba89/lib/libm/man/atan2.3#L150
  2. \(** renders just fine for me and is different from the simple ASCII asterisk so I find the "The old roff escape doesn't render anywhere" assertion doubtful.

Hi! Thanks, can you tell us more about that? It Renders just fine... in vt on FreeBSD 14.3-RELEASE with the default font size? In x11 on alacritty terminal in KDE Plasma with the noto fonts? On gnome help 3.30.1?