Page MenuHomeFreeBSD

Use -fPIC on all arches; lua builds the object files into a shared lib.
ClosedPublic

Authored by ian on Feb 20 2016, 3:49 AM.

Details

Summary

Since the object files get built into a shared lib, using -fPIC on all arches is the right thing to do, instead of adding it to each new arch that comes along which doesn't accidentally allow non-PIC modules in shared libs.

This fixes PR 207324

Test Plan

Build- and run-tested on i386, amd64, arm, armv6.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ian retitled this revision from to Use -fPIC on all arches; lua builds the object files into a shared lib..Feb 20 2016, 3:49 AM
ian updated this object.
ian edited the test plan for this revision. (Show Details)
ian added reviewers: mat, sbruno.
ian set the repository for this revision to rP FreeBSD ports repository.
ian updated this revision to Diff 13541.
mat edited edge metadata.Feb 20 2016, 10:29 AM
mat accepted this revision.
This revision is now accepted and ready to land.Feb 20 2016, 10:29 AM
This revision was automatically updated to reflect the committed changes.