Page MenuHomeFreeBSD

Use -fPIC on all arches; lua builds the object files into a shared lib.
ClosedPublic

Authored by ian on Feb 20 2016, 3:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 14, 5:46 PM
Unknown Object (File)
Fri, Jun 14, 5:45 PM
Unknown Object (File)
Fri, Jun 14, 11:32 AM
Unknown Object (File)
Wed, Jun 12, 9:44 AM
Unknown Object (File)
Wed, Jun 12, 9:42 AM
Unknown Object (File)
Wed, Jun 12, 8:32 AM
Unknown Object (File)
Fri, Jun 7, 3:05 PM
Unknown Object (File)
May 12 2024, 10:50 PM
Subscribers
None

Details

Summary

Since the object files get built into a shared lib, using -fPIC on all arches is the right thing to do, instead of adding it to each new arch that comes along which doesn't accidentally allow non-PIC modules in shared libs.

This fixes PR 207324

Test Plan

Build- and run-tested on i386, amd64, arm, armv6.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ian retitled this revision from to Use -fPIC on all arches; lua builds the object files into a shared lib..
ian updated this object.
ian edited the test plan for this revision. (Show Details)
ian added reviewers: mat, sbruno.
ian set the repository for this revision to rP FreeBSD ports repository.
mat edited edge metadata.
This revision is now accepted and ready to land.Feb 20 2016, 10:29 AM
This revision was automatically updated to reflect the committed changes.