Page MenuHomeFreeBSD
Differential D53617

virtual_oss(8): Use kldload(2) instead of system(3)
ClosedPublic
Actions

Authored by christos on Nov 6 2025, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 8, 3:43 PM
Unknown Object (File)
Wed, Apr 29, 12:50 PM
Unknown Object (File)
Wed, Apr 29, 10:48 AM
Unknown Object (File)
Tue, Apr 28, 4:32 PM
Unknown Object (File)
Fri, Apr 24, 4:14 PM
Unknown Object (File)
Tue, Apr 21, 11:09 AM
Unknown Object (File)
Mon, Apr 20, 1:10 PM
Unknown Object (File)
Apr 6 2026, 3:57 AM
View All 42 Files
Subscribers
imp

Details

Reviewers
markj
emaste
imp
Commits
rG4804bb0d4588: virtual_oss(8): Use kldload(2) instead of system(3)
rG7bedc4634d89: virtual_oss(8): Use kldload(2) instead of system(3)
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Nov 6 2025, 3:16 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 6 2025, 3:16 PM
christos requested review of this revision.Nov 6 2025, 3:16 PM
Harbormaster completed remote builds in B68460: Diff 165957.Nov 6 2025, 3:16 PM
markj accepted this revision.Nov 6 2025, 3:38 PM
This revision is now accepted and ready to land.Nov 6 2025, 3:38 PM
emaste accepted this revision.Nov 6 2025, 3:42 PM

Tweak error text - let's be explicit since we no longer have the "kldload" text to give a hint that it's a kernel module

usr.sbin/virtual_oss/virtual_oss/main.c
2545
christos marked an inline comment as done.Nov 6 2025, 4:02 PM
imp accepted this revision.Nov 6 2025, 5:09 PM

whatever you think best for that message. This is good otherwise.

usr.sbin/virtual_oss/virtual_oss/main.c
2545

or "cuse.ko"

emaste added inline comments.Nov 6 2025, 5:10 PM
usr.sbin/virtual_oss/virtual_oss/main.c
2545

Yeah that would be good too

christos marked 2 inline comments as done.Nov 7 2025, 1:39 PM
Closed by commit rG7bedc4634d89: virtual_oss(8): Use kldload(2) instead of system(3) (authored by christos). · Explain WhyNov 11 2025, 12:14 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG7bedc4634d89: virtual_oss(8): Use kldload(2) instead of system(3).
christos added a commit: rG4804bb0d4588: virtual_oss(8): Use kldload(2) instead of system(3).Nov 18 2025, 12:53 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
virtual_oss/
virtual_oss/
9 lines

Diff 166228

View Options

usr.sbin/virtual_oss/virtual_oss/main.c

Loading...