virtual_oss(8): Use kldload(2) instead of system(3)
ClosedPublic
Actions

Authored by christos on Thu, Nov 6, 3:16 PM.

Details

Reviewers

markj
emaste
imp

Commits

rG7bedc4634d89: virtual_oss(8): Use kldload(2) instead of system(3)

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Thu, Nov 6, 3:16 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Nov 6, 3:16 PM

christos requested review of this revision.Thu, Nov 6, 3:16 PM

Harbormaster completed remote builds in B68460: Diff 165957.Thu, Nov 6, 3:16 PM

markj accepted this revision.Thu, Nov 6, 3:38 PM

This revision is now accepted and ready to land.Thu, Nov 6, 3:38 PM

Tweak error text - let's be explicit since we no longer have the "kldload" text to give a hint that it's a kernel module

usr.sbin/virtual_oss/virtual_oss/main.c
2545

christos marked an inline comment as done.Thu, Nov 6, 4:02 PM

whatever you think best for that message. This is good otherwise.

usr.sbin/virtual_oss/virtual_oss/main.c
2545	or "cuse.ko"

emaste added inline comments.Thu, Nov 6, 5:10 PM

usr.sbin/virtual_oss/virtual_oss/main.c
2545	Yeah that would be good too

christos marked 2 inline comments as done.Fri, Nov 7, 1:39 PM

Closed by commit rG7bedc4634d89: virtual_oss(8): Use kldload(2) instead of system(3) (authored by christos). · Explain WhyTue, Nov 11, 12:14 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG7bedc4634d89: virtual_oss(8): Use kldload(2) instead of system(3).

Revision Contents
Changeset List

Path

Size

usr.sbin/

virtual_oss/

main.c

9 lines

Diff 166228

View Options

usr.sbin/virtual_oss/virtual_oss/main.c

virtual_oss(8): Use kldload(2) instead of system(3)ClosedPublicActions