Paths

Table of Contentst

Differential D53503

mixer(8): Update FILES section
ClosedPublic
Actions

Authored by christos on Oct 31 2025, 5:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 29, 5:13 PM

	Unknown Object (File)
	Sun, Nov 16, 5:06 PM

	Unknown Object (File)
	Fri, Nov 7, 4:58 PM

	Unknown Object (File)
	Fri, Nov 7, 11:28 AM

	Unknown Object (File)
	Fri, Nov 7, 2:06 AM

	Unknown Object (File)
	Fri, Nov 7, 2:06 AM

	Unknown Object (File)
	Fri, Nov 7, 2:06 AM

	Unknown Object (File)
	Fri, Nov 7, 2:06 AM

View All 22 Files

Subscribers

Details

Reviewers

emaste
ziaee

Commits

rG9eb7d0c65dea: mixer(8): Update FILES section
rG26e7e9a6a2a2: mixer(8): Update FILES section

Summary

While here, change "N" to "%d" to match sound.4's notation.

Sponsored by: The FreeBSD Foundation
MFC after: 4 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Oct 31 2025, 5:57 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 31 2025, 5:57 PM

christos requested review of this revision.Oct 31 2025, 5:57 PM

Harbormaster completed remote builds in B68314: Diff 165591.Oct 31 2025, 5:57 PM

emaste added inline comments.Oct 31 2025, 6:15 PM

usr.sbin/mixer/mixer.8
31	Do we normally put printf format specifiers in user-facing man pages, outside of sound(4)? It seems a bit strange to me
53	if we go with this format I'd probably use `where %d represents`. `pcmN, where N is` doesn't require any extra knowledge but `pcm%d, where the number` requires that the user know `%d` represents a number.

Revert %d notation, but use X instead of N to match sndctl.8's notation (the
commit message has also been adapted accordingly).

Harbormaster completed remote builds in B68316: Diff 165596.Oct 31 2025, 6:26 PM

LGTM with one small nit. X seems more natural to me than N.

usr.sbin/mixer/mixer.8
264

This revision is now accepted and ready to land.Oct 31 2025, 6:34 PM

christos marked an inline comment as done.Fri, Oct 31, 6:57 PM

Closed by commit rG26e7e9a6a2a2: mixer(8): Update FILES section (authored by christos). · Explain WhyThu, Nov 6, 12:57 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG26e7e9a6a2a2: mixer(8): Update FILES section.

christos added a commit: rG9eb7d0c65dea: mixer(8): Update FILES section.Mon, Nov 10, 10:00 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

mixer/

44 lines

Diff 165947

usr.sbin/mixer/mixer.8

Loading...