riscv: Treat pointer register as an input in fpe_store
ClosedPublic
Actions

Authored by jhb on Oct 29 2025, 4:11 PM.

Details

Reviewers

Group Reviewers

Commits

rG054da4a6d033: riscv: Treat pointer register as an input in fpe_store
rG0b5e4af65d0d: riscv: Treat pointer register as an input in fpe_store
rG91f66f9b377e: riscv: Treat pointer register as an input in fpe_store

Summary

Obtained from: CheriBSD
Sponsored by: AFRL, DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 29 2025, 4:11 PM

Herald added subscribers: riscv, imp. · View Herald TranscriptOct 29 2025, 4:11 PM

jhb requested review of this revision.Oct 29 2025, 4:11 PM

Herald added a reviewer: cheri. · View Herald TranscriptOct 29 2025, 4:11 PM

Harbormaster completed remote builds in B68229: Diff 165332.Oct 29 2025, 4:11 PM

jrtc27 mentioned this in D45697: riscv: add FPE code.Oct 29 2025, 4:11 PM

Maybe a description along the lines of:

The contents of the memory is an output, but the pointer to that memory
is an input. This was correct in the original version of D45697, but
when adding appropriate clobbers, the pointer operand was incorrectly
switched to an output rather than left an input for fpe_store.

Fixes:		44d4ee7f3dad ("riscv: add FPE code.")
MFC after:	1 day

Short MFC because of the 15.0 release cycle, so this way it'll get into the BETA4(?) build at the end of this week.

This revision is now accepted and ready to land.Oct 29 2025, 4:28 PM

Closed by commit rG91f66f9b377e: riscv: Treat pointer register as an input in fpe_store (authored by jhb). · Explain WhyOct 30 2025, 7:54 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG91f66f9b377e: riscv: Treat pointer register as an input in fpe_store.

cperciva added a commit: rG0b5e4af65d0d: riscv: Treat pointer register as an input in fpe_store.Nov 5 2025, 8:17 PM

cperciva added a commit: rG054da4a6d033: riscv: Treat pointer register as an input in fpe_store.