Fixes: 01addd846c64 ("gone_in: make it __printflike()")
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Thanks for tagging me!
| share/man/man9/gone_in.9 | ||
|---|---|---|
| 38 | I don't really know how this is used. Is the ellipsis signifying that like, there can be a second "const char *msg"? | |
| share/man/man9/gone_in.9 | ||
|---|---|---|
| 38 | No, it means there are optional additional arguments (of unspecified type). See printf(3) or printf(9) printf(const char *fmt, ...); | |
Comment Actions
gone_in and gone_in_dev append a message only before major, so the string would not get a newline otherwise.
We should add some sort of "Will be removed without further notice" message for >= major but I still think it makes sense to use the newline in the message passed to gone_in / gone_in_dev since the messages may be long and may be multiple lines already.
We should also rationalize the style for WARNING/Warning etc.