security/letsencrypt.sh: Fix cleanup bug

[brnrd]

Summary

Proposed commit log

security/letsencrypt.sh: Update to 2016-02-17

  - Update to latest version
  - Includes upstream fix for cleanup command [1]
  - Add PORTDOCS

https://github.com/lukas2511/letsencrypt.sh/pull/137 [1]

Reviewed_by:	sascha_root-login.org (maintainer), feld (mentor), koobs (mentor)
Approved by:	(mentor)
Differential_Revision:	D5297

Test Plan

• portlint -AC
• poudriere testport
• Check DOCS option on/off

[koobs]

Change "Include upstream fix" line to have a bit more info in the commit log message.

security/letsencrypt.sh/Makefile

64 ↗

(On Diff #13351)

Add DOCS option and use post-install-DOCS-on: ?

[brnrd]

In D5297#112936, @koobs wrote:

Change "Include upstream fix" line to have a bit more info in the commit log message.

security/letsencrypt.sh/Makefile

64 ↗

(On Diff #13351)

That's what I had initially but this is not required with the ports framework. PORTDOCS takes care of that. Compare

$ make WITH="DOCS" clean check-plist
<snip>
install  -m 444 /usr/ports/security/letsencrypt.sh/work/letsencrypt.sh-dec95ff/README.md /usr/ports/security/letsencrypt.sh/work/stage/usr/local/share/doc/letsencrypt.sh
===> No pkg-plist issues found (check-plist)
$ make WITH="DOCS" -V PORTDOCS
README.md
$ grep README work/.PLIST.mktmp
/usr/local/share/doc/letsencrypt.sh/README.md

with

$ make WITHOUT="DOCS" clean check-plist
<snip>
install  -m 444 /usr/ports/security/letsencrypt.sh/work/letsencrypt.sh-dec95ff/README.md /usr/ports/security/letsencrypt.sh/work/stage/usr/local/share/doc/letsencrypt.sh
===> No pkg-plist issues found (check-plist)
$ make WITHOUT="DOCS" -V PORTDOCS
README.md
$ grep README work/.PLIST.mktmp
<emtpy>

make check-plist returns no errors even though ${STAGEDIR}/usr/local/share/letsencrypt.sh/README.md exists. Ports framework deals with DOCS transparently.

[brnrd]

Update to 2015-02-17

[koobs]

This doesn't mention maintainer approval requirement

[brnrd]

In D5297#113456, @koobs wrote:

This doesn't mention maintainer approval requirement

Forgot to add maintainer as reviewer. Fixed!

Awaiting maintainer approval now...

[sascha_root-login.org]

Looks good to me, feel free to commit.