Page MenuHomeFreeBSD

irc/ircd-ratbox: Fix OpenSSL linking and simplify
ClosedPublic

Authored by brnrd on Feb 15 2016, 2:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 13 2024, 11:59 PM
Unknown Object (File)
Dec 26 2023, 7:47 AM
Unknown Object (File)
Dec 20 2023, 8:29 AM
Unknown Object (File)
Dec 13 2023, 3:27 PM
Unknown Object (File)
Nov 18 2023, 11:22 PM
Unknown Object (File)
Nov 18 2023, 11:15 AM
Unknown Object (File)
Nov 13 2023, 2:27 PM
Unknown Object (File)
Nov 10 2023, 7:19 PM
Subscribers
None

Details

Summary

Proposed commit log

irc/ircd-ratbox: Fix OpenSSL linking and simplify

  - Fix linking with ports' ssl libs
  - Fix `contrib` build (used base openssl headers)
  - Re-work EGD detection
  - Use options helpers
  - Simplify REINPLACE with :U defaults

PR:		195796
Reviewed_by:	feld (mentor), koobs (mentor)
Approved by:	(mentor)
Differential_Revision:	D5???
Test Plan
  • portlint -AC (one line reduced)
  • poudriere testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2504
Build 2521: arc lint + arc unit

Event Timeline

brnrd retitled this revision from to irc/ircd-ratbox: Fix OpenSSL linking and simplify.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: feld, koobs.
brnrd added inline comments.
irc/ircd-ratbox/Makefile
69

Honor WITH_OPENSSL_PORT

123

Duplicate line, already fixed in my local repo, part of next arc diff --update

125

Use default values for the replacement. Same effect but simpler.
i.e. if not defined ALIS_SERV, replace ALIS with ALIS.

irc/ircd-ratbox/files/patch-configure
1

No longer needed due to OPENSSL_NO_EGD addition to opensslfeatures.h

irc/ircd-ratbox/files/patch-configure.ac
1

No longer needed due to OPENSSL_NO_EGD addition to opensslfeatures.h

irc/ircd-ratbox/files/patch-libratbox_src_openssl.c
7

Change to OPENSSL_NO_EGD after addition to opensslfeatures.h

irc/ircd-ratbox/files/patch-contrib_Makefile.in
11

contrib was using /usr/include for the openssl headers even when WITH_OPENSSL_PORT was defined.

feld edited edge metadata.
This revision is now accepted and ready to land.Feb 15 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.