Differential D52612

pwait: Fix timeout unit parser
ClosedPublic
Actions

Authored by des on Fri, Sep 19, 11:36 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 9:58 AM

	Unknown Object (File)
	Fri, Oct 10, 3:32 AM

	Unknown Object (File)
	Fri, Oct 10, 3:32 AM

	Unknown Object (File)
	Fri, Oct 10, 3:32 AM

	Unknown Object (File)
	Thu, Oct 9, 10:29 PM

	Unknown Object (File)
	Thu, Oct 2, 10:24 PM

	Unknown Object (File)
	Thu, Oct 2, 9:57 PM

	Unknown Object (File)
	Thu, Oct 2, 5:37 AM

View All 19 Files

Subscribers

Details

Reviewers

markj
0mp

Commits

rG278c371fd2db: pwait: Fix timeout unit parser
rG76fd9309e55e: pwait: Fix timeout unit parser
rG3aac05f56620: pwait: Fix timeout unit parser

Summary

The timeout parser would check the first character after the number and
ignore any subsequent ones.

While here, switch to bool for booleans and fix some style nits.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Fri, Sep 19, 11:36 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 19, 11:36 AM

des requested review of this revision.Fri, Sep 19, 11:36 AM

Harbormaster completed remote builds in B67156: Diff 162399.Fri, Sep 19, 11:36 AM

markj accepted this revision.Sat, Sep 20, 12:17 PM

This revision is now accepted and ready to land.Sat, Sep 20, 12:17 PM

0mp accepted this revision.Mon, Sep 22, 4:54 PM

Closed by commit rG3aac05f56620: pwait: Fix timeout unit parser (authored by des). · Explain WhyTue, Sep 23, 12:59 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG3aac05f56620: pwait: Fix timeout unit parser.

des added a commit: rG76fd9309e55e: pwait: Fix timeout unit parser.Thu, Oct 2, 8:21 AM

des added a commit: rG278c371fd2db: pwait: Fix timeout unit parser.

Revision Contents
Changeset List

Path

Size

bin/

pwait/

30 lines

Diff 162648

bin/pwait/pwait.c

Loading...