Page MenuHomeFreeBSD

Fix CFLAGS handling in lua53 patch
ClosedPublic

Authored by ian on Feb 11 2016, 4:07 PM.

Details

Summary

The ?= assignment of CFLAGS (not present in earlier lua5x patches) results in MYCFLAGS, passed from the port makefile, never getting assigned to CFLAGS during the lua build. The result is a copy of lua that has none of the posix support functions in it.

CFLAGS set in the outer environment by the user or make.conf get passed in via the MYCFLAGS mechanism, so remove the -O2 and let the outer environment control optimization level.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ian retitled this revision from to Fix CFLAGS handling in lua53 patch.
ian updated this object.
ian edited the test plan for this revision. (Show Details)
ian added reviewers: mat, sbruno, bapt.
ian set the repository for this revision to rP FreeBSD ports repository.
mat edited edge metadata.

"I have no idea what this does"

Macro shipit:

This revision is now accepted and ready to land.Feb 19 2016, 5:14 PM
sbruno edited edge metadata.
This revision was automatically updated to reflect the committed changes.