Page MenuHomeFreeBSD
Differential D52428

net-mgmt/net-snmp: fix build on FreeBSD 15.0-ALPHA1+
ClosedPublic
Actions

Authored by rikka.goering_outlook.de on Sep 8 2025, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 8:06 PM
Unknown Object (File)
Sat, Oct 11, 11:17 PM
Unknown Object (File)
Sat, Oct 11, 11:17 PM
Unknown Object (File)
Sat, Oct 11, 1:59 PM
Unknown Object (File)
Sat, Oct 11, 1:59 PM
Unknown Object (File)
Sat, Oct 11, 1:59 PM
Unknown Object (File)
Sat, Oct 11, 1:59 PM
Unknown Object (File)
Sat, Oct 11, 5:41 AM
View All 25 Files
Subscribers
eduardo
glebius

Details

Reviewers
zi
eduardo
Group Reviewers
Ports Committers
Commits
R11:ce3f0c2603bf: net-mgmt/net-snmp: Fix build on 16
Summary

FreeBSD 15.0-ALPHA1+ exposes TCP pcblist entries as struct xtcpcb, where t_state
resides. Net-SNMP's tcpTable.c still treated entries as struct xinpcb, causing
compile errors (no member t_state / xt_inp path mismatch).

This change:

  • Includes <sys/param.h>, <netinet/tcp_var.h>, <netinet/in_pcb.h> on FreeBSD.
  • Sets NS_ELEM to struct xtcpcb on __FreeBSD_version >= 1500064.
  • Keeps the old xinpcb path on older systems.

No functional change expected on 14.x; fixes build on 15.0-ALPHA1+.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289351

Test Plan
  • Build on 14.3-RELEASE: OK (no change).
  • Requesting confirmation build on 15.0-ALPHA1/HEAD.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rikka.goering_outlook.de requested review of this revision.Sep 8 2025, 5:38 PM
rikka.goering_outlook.de created this revision.
Harbormaster completed remote builds in B66897: Diff 161729.Sep 8 2025, 5:38 PM
rikka.goering_outlook.de updated this revision to Diff 161731.Sep 8 2025, 5:42 PM

net-mgmt/net-snmp: fix build on FreeBSD 15.0-ALPHA1+

Harbormaster completed remote builds in B66899: Diff 161731.Sep 8 2025, 5:42 PM
rikka.goering_outlook.de retitled this revision from Updated to current working status to net-mgmt/net-snmp: fix build on FreeBSD 15.0-ALPHA1+.Sep 8 2025, 5:47 PM
rikka.goering_outlook.de edited the summary of this revision. (Show Details)
rikka.goering_outlook.de edited the test plan for this revision. (Show Details)
rikka.goering_outlook.de added a reviewer: Contributor Reviewers (ports).
rikka.goering_outlook.de added subscribers: eduardo, zi.
rikka.goering_outlook.de edited the summary of this revision. (Show Details)Sep 8 2025, 5:53 PM
rikka.goering_outlook.de edited reviewers, added: Ports Committers; removed: Contributor Reviewers (ports).
rikka.goering_outlook.de updated this revision to Diff 161755.Sep 8 2025, 10:37 PM
rikka.goering_outlook.de edited the summary of this revision. (Show Details)
  • Added missing include <sys/socketvar.h>
  • Ensured correct include order
  • Corrected formatting
Harbormaster completed remote builds in B66911: Diff 161755.Sep 8 2025, 10:37 PM
rikka.goering_outlook.de added a reviewer: glebius.Sep 8 2025, 10:41 PM

I’ve added glebius@ as a reviewer since this breakage originates from src commit c62ae124cc78, which moved t_state into struct xtcpcb and guarded its declaration. Since they authored that change, it seemed appropriate to get confirmation that using xtcpcb is indeed the correct long-term interface for userland consumers like net-snmp.

glebius requested changes to this revision.Sep 9 2025, 8:56 PM

Not a correct fix. See discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289351

This revision now requires changes to proceed.Sep 9 2025, 8:56 PM
rikka.goering_outlook.de updated this revision to Diff 161839.Sep 9 2025, 11:32 PM
  • include/net-snmp/system/freebsd16.h (includes freebsd15.h) and defines freebsd15 for compatibility checks.
  • Install the new header (Makefile.in + pkg-plist).

Mirrors 03e9f0cdfac68b11552c62cac1eaa27690fc0d32 (freebsd15.h) for 16. No functional agent changes.

Harbormaster completed remote builds in B66937: Diff 161839.Sep 9 2025, 11:32 PM
rikka.goering_outlook.de added a comment.Sep 9 2025, 11:33 PM

Thanks Gleb - understood. My first attempt went the wrong way by touching tcpTable.c. I’ve now reworked the patch to follow commit 03e9f0cdfac68b11552c62cac1eaa27690fc0d32, adding freebsd16.h and updating the build/install list so 16 picks up the same path as 15. No other functional changes.

rikka.goering_outlook.de added a comment.Sep 10 2025, 12:58 AM

Updated patch posted, following Gleb’s suggestion; confirmed working by Cy on 16. Ready for review.

rikka.goering_outlook.de edited reviewers, added: zi; removed: glebius.Sep 10 2025, 6:16 AM
rikka.goering_outlook.de edited subscribers, added: glebius; removed: zi.
eduardo added a reviewer: eduardo.Sep 10 2025, 5:08 PM

LGTM as it follows past patch procedures. Lets unbreak build.

eduardo accepted this revision.Sep 10 2025, 5:09 PM
This revision is now accepted and ready to land.Sep 10 2025, 5:09 PM
Closed by commit R11:ce3f0c2603bf: net-mgmt/net-snmp: Fix build on 16 (authored by rkoberman_gmail.com, committed by eduardo). · Explain WhySep 10 2025, 5:19 PM
This revision was automatically updated to reflect the committed changes.
eduardo added a commit: R11:ce3f0c2603bf: net-mgmt/net-snmp: Fix build on 16.
rikka.goering_outlook.de added a comment.Sep 14 2025, 12:02 AM

The patch has been merged upstream to master and is expected to ship in the next release (likely 5.10 or 6.1).

Revision Contents
Changeset List

PathSize
net-mgmt/
net-snmp/
files/
2 lines
6 lines
1 line

Diff 161873

View Options

net-mgmt/net-snmp/files/patch-Makefile.in

Loading...
View Options

net-mgmt/net-snmp/files/patch-include_net-snmp_system_freebsd16.h

Loading...
View Options

net-mgmt/net-snmp/pkg-plist

Loading...