Page MenuHomeFreeBSD
Differential D52390

e1000: remove unused header file
Needs ReviewPublic
Actions

Authored by jmg on Sep 4 2025, 11:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 6:22 AM
Unknown Object (File)
Sat, Oct 11, 3:15 PM
Unknown Object (File)
Sat, Oct 11, 3:15 PM
Unknown Object (File)
Sat, Oct 11, 6:46 AM
Unknown Object (File)
Wed, Oct 8, 9:33 PM
Unknown Object (File)
Fri, Oct 3, 12:04 AM
Unknown Object (File)
Thu, Oct 2, 11:43 PM
Unknown Object (File)
Sat, Sep 27, 2:48 AM
View All 21 Files
Subscribers
imp
kgalazka

Details

Reviewers
kbowling
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66831
Build 63714: arc lint + arc unit

Event Timeline

jmg created this revision.Sep 4 2025, 11:17 PM
Owners added a reviewer: Restricted Owners Package.Sep 4 2025, 11:17 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 4 2025, 11:17 PM
jmg requested review of this revision.Sep 4 2025, 11:17 PM
Harbormaster completed remote builds in B66831: Diff 161564.Sep 4 2025, 11:17 PM
jmg added a reviewer: kbowling.Sep 4 2025, 11:35 PM
kbowling added a comment.EditedSep 5 2025, 12:07 AM

There are two possible concerns that come to mind:

  1. Can you confirm none of the functions are needed for PF (iovctl) support? It would be nice to bring that in, even if you/Juniper have no plans to.
  2. This driver is "upstream" for various other operating systems (QNX, RTEMS, Haiku, others). This is less of a concern if we know what we are doing WRT 1.
kgalazka added a subscriber: kgalazka.Tue, Oct 7, 5:37 PM

This file might be a collateral damage of splitting PF and VF drivers on Linux. We should have all definitions from this file in other places, but let me double check if there are no differences.

Revision Contents
Changeset List

PathSize
sys/
dev/
e1000/

Diff 161564

View Options

sys/dev/e1000/e1000_vf.h

Loading...