Page MenuHomeFreeBSD
Differential D52077

LinuxKPI: add __struct_size
ClosedPublic
Actions

Authored by bz on Aug 21 2025, 9:00 AM.
Tags
None
Referenced Files
F132391656: D52077.id161467.diff
Thu, Oct 16, 12:42 PM
Unknown Object (File)
Sun, Oct 12, 12:27 PM
Unknown Object (File)
Sun, Oct 12, 12:27 PM
Unknown Object (File)
Sun, Oct 12, 1:29 AM
Unknown Object (File)
Sun, Oct 12, 1:29 AM
Unknown Object (File)
Sun, Oct 12, 1:29 AM
Unknown Object (File)
Sat, Oct 11, 3:58 PM
Unknown Object (File)
Thu, Oct 9, 8:50 PM
View All 28 Files
Subscribers
dumbbell
emaste
imp

Details

Reviewers
dumbbell
Group Reviewers
linuxkpi
Commits
rG310885b40ad2: LinuxKPI: add __struct_size
rGff5bcb742899: LinuxKPI: add __struct_size
Summary

Use builtin_object_size() by default.
If builtin_dynamic_object_size() is available use that instead.

I would hope that in a future version we can remove the conditional
checks but in order to be able to MFC this without checking all
compiler versions simply keep it this way for now.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Aug 21 2025, 9:00 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptAug 21 2025, 9:00 AM
bz requested review of this revision.Aug 21 2025, 9:00 AM
Harbormaster completed remote builds in B66415: Diff 160731.Aug 21 2025, 9:00 AM
dumbbell added a subscriber: dumbbell.Sep 3 2025, 8:51 PM
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/compiler.h
133

Just a tiny comment: I find easier to reason about when a check is if (condition) rather than if (!condition). Any reason to handle the negative code path first?

bz updated this revision to Diff 161467.Sep 3 2025, 10:05 PM

Switch order.

Harbormaster completed remote builds in B66801: Diff 161467.Sep 3 2025, 10:05 PM
bz marked an inline comment as done.Sep 3 2025, 10:05 PM
dumbbell accepted this revision.Sep 4 2025, 4:15 PM
This revision is now accepted and ready to land.Sep 4 2025, 4:15 PM
Closed by commit rGff5bcb742899: LinuxKPI: add __struct_size (authored by bz). · Explain WhySep 5 2025, 11:29 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGff5bcb742899: LinuxKPI: add __struct_size.
bz added a commit: rG310885b40ad2: LinuxKPI: add __struct_size.Sep 15 2025, 7:13 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
6 lines

Diff 161639

View Options

sys/compat/linuxkpi/common/include/linux/compiler.h

Loading...