Page MenuHomeFreeBSD
Differential D51933

gpioc: remove unnecessary bus_generic_* calls
ClosedPublic
Actions

Authored by vexeduxr on Aug 16 2025, 10:36 AM.
Tags
None
Referenced Files
F133115869: D51933.id161091.diff
Thu, Oct 23, 2:46 AM
Unknown Object (File)
Thu, Oct 16, 1:46 AM
Unknown Object (File)
Sun, Oct 12, 4:12 AM
Unknown Object (File)
Sat, Oct 11, 10:44 PM
Unknown Object (File)
Sat, Oct 11, 10:44 PM
Unknown Object (File)
Sat, Oct 11, 10:44 PM
Unknown Object (File)
Sat, Oct 11, 1:25 PM
Unknown Object (File)
Sat, Oct 11, 5:10 AM
View All 37 Files
Subscribers
loos

Details

Reviewers
imp
mmel
andrew
jhb
Commits
rGef73953ebdc2: gpioc: remove unnecessary bus_generic_* calls
Summary

gpioc never has any children, so there's no need to call these.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vexeduxr created this revision.Aug 16 2025, 10:36 AM
Herald added a subscriber: loos. · View Herald TranscriptAug 16 2025, 10:36 AM
vexeduxr requested review of this revision.Aug 16 2025, 10:36 AM
Harbormaster completed remote builds in B66285: Diff 160428.Aug 16 2025, 10:36 AM
andrew added inline comments.Aug 16 2025, 2:29 PM
sys/dev/gpio/gpioc.c
1064–1065

Are these needed?

vexeduxr added inline comments.Aug 16 2025, 4:18 PM
sys/dev/gpio/gpioc.c
1064–1065

Ah, didn't notice those. They aren't.

vexeduxr retitled this revision from gpioc: remove unnecessary bus_generic_detach call to gpioc: remove unnecessary bus_generic_* calls.Aug 16 2025, 4:30 PM
vexeduxr edited the summary of this revision. (Show Details)
vexeduxr updated this revision to Diff 160430.Aug 16 2025, 4:32 PM

Remove unnecessary devmethods too.

Harbormaster completed remote builds in B66286: Diff 160430.Aug 16 2025, 4:32 PM
jhb accepted this revision.Aug 19 2025, 2:37 PM
This revision is now accepted and ready to land.Aug 19 2025, 2:37 PM
Closed by commit rGef73953ebdc2: gpioc: remove unnecessary bus_generic_* calls (authored by vexeduxr). · Explain WhyAug 27 2025, 9:57 PM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rGef73953ebdc2: gpioc: remove unnecessary bus_generic_* calls.

Revision Contents
Changeset List

PathSize
sys/
dev/
gpio/
7 lines

Diff 161091

View Options

sys/dev/gpio/gpioc.c

Loading...