Page MenuHomeFreeBSD

last: Mild style cleanup
ClosedPublic

Authored by des on Aug 12 2025, 3:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 21, 12:12 PM
Unknown Object (File)
Thu, Mar 12, 10:19 AM
Unknown Object (File)
Wed, Mar 11, 5:29 PM
Unknown Object (File)
Wed, Mar 11, 1:57 AM
Unknown Object (File)
Feb 25 2026, 4:54 AM
Unknown Object (File)
Feb 17 2026, 9:31 AM
Unknown Object (File)
Feb 16 2026, 11:36 PM
Unknown Object (File)
Feb 16 2026, 1:18 AM
Subscribers

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG40c2b622d825: last: Mild style cleanup
Summary
  • Prefer explicit NULL comparisons to using pointers as booleans
  • Prefer explicit 0 comparisons to using strcmp() as a predicate
  • Avoid use of strcpy()

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Aug 12 2025, 3:56 PM
markj added a subscriber: markj.
markj added inline comments.
usr.bin/last/last.c
513

Not a problem in practice, but it's not very nice that this helper function sometimes returns a malloc()ed buffer, and sometimes not.

This revision is now accepted and ready to land.Aug 12 2025, 4:37 PM
This revision was automatically updated to reflect the committed changes.