Page MenuHomeFreeBSD
Differential D51876

last: Mild style cleanup
ClosedPublic
Actions

Authored by des on Aug 12 2025, 3:56 PM.
Tags
None
Referenced Files
F167156231: D51876.id160250.diff
Wed, Aug 19, 1:29 PM
Unknown Object (File)
Tue, Aug 18, 7:37 PM
Unknown Object (File)
Sun, Aug 16, 4:30 AM
Unknown Object (File)
Fri, Aug 7, 7:10 PM
Unknown Object (File)
Thu, Aug 6, 12:15 PM
Unknown Object (File)
Wed, Aug 5, 5:31 AM
Unknown Object (File)
Sat, Jul 25, 9:14 PM
Unknown Object (File)
Sat, Jul 25, 3:06 PM
View All 61 Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG40c2b622d825: last: Mild style cleanup
Summary
  • Prefer explicit NULL comparisons to using pointers as booleans
  • Prefer explicit 0 comparisons to using strcmp() as a predicate
  • Avoid use of strcpy()

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Aug 12 2025, 3:56 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 12 2025, 3:56 PM
des requested review of this revision.Aug 12 2025, 3:56 PM
Harbormaster completed remote builds in B66198: Diff 160250.Aug 12 2025, 3:56 PM
markj accepted this revision as: markj.Aug 12 2025, 4:37 PM
markj added a subscriber: markj.
markj added inline comments.
usr.bin/last/last.c
513

Not a problem in practice, but it's not very nice that this helper function sometimes returns a malloc()ed buffer, and sometimes not.

This revision is now accepted and ready to land.Aug 12 2025, 4:37 PM
Closed by commit rG40c2b622d825: last: Mild style cleanup (authored by des). · Explain WhyAug 12 2025, 5:21 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG40c2b622d825: last: Mild style cleanup.

Revision Contents
Changeset List

PathSize
usr.bin/
last/
27 lines

Diff 160255

View Options

usr.bin/last/last.c

Loading...