Page MenuHomeFreeBSD
Differential D51836

timerfd_read(): stop setting td_rtcgen
ClosedPublic
Actions

Authored by kib on Aug 8 2025, 10:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 22, 2:30 AM
Unknown Object (File)
Sun, Oct 12, 7:12 PM
Unknown Object (File)
Sun, Oct 12, 5:42 PM
Unknown Object (File)
Fri, Oct 10, 3:57 PM
Unknown Object (File)
Fri, Oct 10, 3:57 PM
Unknown Object (File)
Fri, Oct 10, 3:57 PM
Unknown Object (File)
Fri, Oct 10, 3:57 PM
Unknown Object (File)
Fri, Oct 10, 9:52 AM
View All 38 Files
Subscribers
imp
olce

Details

Reviewers
markj
imp
Commits
rGe8b37e754589: timerfd_read(): stop setting td_rtcgen
Summary
The sleep is not time-bound.  More, setting td_rtcgen and not clearing
it would cause future sleeps to be spuriously interrupted.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Aug 8 2025, 10:51 PM
Herald added subscribers: olce, imp. · View Herald TranscriptAug 8 2025, 10:51 PM
kib requested review of this revision.Aug 8 2025, 10:51 PM
kib updated this revision to Diff 160099.Aug 8 2025, 11:01 PM
kib retitled this revision from timerfd_read(): avoid leaking td_rtcgen to timerfd_read(): stop setting td_rtcgen.
kib edited the summary of this revision. (Show Details)

Redo the patch completely: setting td_rtcgen is not needed at all.

imp accepted this revision.Aug 8 2025, 11:34 PM
This revision is now accepted and ready to land.Aug 8 2025, 11:34 PM
markj accepted this revision.Aug 9 2025, 1:27 PM
Closed by commit rGe8b37e754589: timerfd_read(): stop setting td_rtcgen (authored by kib). · Explain WhyAug 9 2025, 10:05 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGe8b37e754589: timerfd_read(): stop setting td_rtcgen.

Revision Contents
Changeset List

PathSize
sys/
kern/
1 line

Diff 160140

View Options

sys/kern/sys_timerfd.c

Loading...