Page MenuHomeFreeBSD
Differential D51803

Mk/Uses/cargo.mk: Fix incorrect linker argument in RUSTFLAGS
ClosedPublic
Actions

Authored by michaelo on Aug 7 2025, 7:21 PM.
Tags
None
Referenced Files
F132395319: D51803.id159993.diff
Thu, Oct 16, 1:34 PM
Unknown Object (File)
Mon, Oct 13, 4:07 PM
Unknown Object (File)
Mon, Oct 13, 4:07 PM
Unknown Object (File)
Wed, Oct 8, 9:49 PM
Unknown Object (File)
Tue, Sep 30, 2:49 AM
Unknown Object (File)
Mon, Sep 29, 10:24 PM
Unknown Object (File)
Sat, Sep 27, 5:32 AM
Unknown Object (File)
Wed, Sep 24, 6:26 PM
View All 27 Files
Subscribers
None

Details

Reviewers
jrm
otis
mikael
Group Reviewers
rust
Commits
R11:fcccfcbf717c: Mk/Uses/cargo.mk: Fix incorrect linker argument in RUSTFLAGS
R11:fe640c9c7d63: Mk/Uses/cargo.mk: Fix incorrect linker argument in RUSTFLAGS
Summary

According to the manpage of rustc(1) it is: link-args='-flag1 -flag2'
an 's' was missing.

Approved by: jrm (mentor), otis (mentor)
MFH: 2025Q3

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo requested review of this revision.Aug 7 2025, 7:21 PM
michaelo created this revision.
Harbormaster completed remote builds in B66071: Diff 159993.Aug 7 2025, 7:21 PM
michaelo added a comment.Aug 7 2025, 7:22 PM

Please add reviewers as you think necessary.

michaelo added a reviewer: rust.Aug 7 2025, 7:22 PM
michaelo retitled this revision from Mk/Uses/cargo.mk: Fix incorrect linker argument to Mk/Uses/cargo.mk: Fix incorrect linker argument in RUSTFLAGS.Aug 7 2025, 7:26 PM
jrm accepted this revision.Aug 17 2025, 6:56 PM

Looks good to me. It would be good to hear from someone rust.

This revision is now accepted and ready to land.Aug 17 2025, 6:56 PM
otis added a comment.Aug 17 2025, 8:35 PM

I'm not sure if link-args is a valid argument, can't seem to find any clear documentation on this case.

otis accepted this revision.Aug 17 2025, 8:36 PM

Disregarg, it's in the manual page. LGTM then.

Let's wait for someone from rust team.

michaelo added a comment.Aug 22 2025, 11:50 AM

Related issue: https://reviews.freebsd.org/D51802

michaelo added a comment.Aug 24 2025, 7:10 PM

Will wait for rust reviewers for a couple of more days.

mikael accepted this revision.Aug 25 2025, 12:21 PM
Closed by commit R11:fe640c9c7d63: Mk/Uses/cargo.mk: Fix incorrect linker argument in RUSTFLAGS (authored by michaelo). · Explain WhyAug 25 2025, 3:20 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:fe640c9c7d63: Mk/Uses/cargo.mk: Fix incorrect linker argument in RUSTFLAGS.
michaelo added a commit: R11:fcccfcbf717c: Mk/Uses/cargo.mk: Fix incorrect linker argument in RUSTFLAGS.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
2 lines

Diff 160934

View Options

Mk/Uses/cargo.mk

Loading...