Page MenuHomeFreeBSD
Differential D51795

indent: Simplify test script
ClosedPublic
Actions

Authored by des on Aug 7 2025, 4:35 PM.
Tags
None
Referenced Files
F132792835: D51795.id160013.diff
Mon, Oct 20, 12:20 AM
Unknown Object (File)
Sun, Oct 12, 7:11 PM
Unknown Object (File)
Fri, Oct 10, 12:12 PM
Unknown Object (File)
Fri, Oct 10, 5:27 AM
Unknown Object (File)
Fri, Oct 10, 5:27 AM
Unknown Object (File)
Fri, Oct 10, 5:27 AM
Unknown Object (File)
Fri, Oct 10, 5:27 AM
Unknown Object (File)
Thu, Oct 9, 11:58 PM
View All 37 Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG831799f6d3a9: indent: Simplify test script
rG9bdd39b9fe52: indent: Simplify test script
rG0ecc679fd3da: indent: Simplify test script
Summary

Much of the test script was concerned with working around RCS tags and
dealing with cases which don't apply to indent.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Aug 7 2025, 4:35 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 7 2025, 4:35 PM
des requested review of this revision.Aug 7 2025, 4:35 PM
Harbormaster completed remote builds in B66067: Diff 159973.Aug 7 2025, 4:35 PM
des added a child revision: D51796: indent: Fix buffer overflow.Aug 7 2025, 4:35 PM
markj added a subscriber: markj.Aug 7 2025, 7:04 PM
markj added inline comments.
usr.bin/indent/tests/functional_test.sh
3

Existing license text should be preserved.

34–35

Since it was declared local before, though it doesn't really matter. Alternately, don't bother using local at all.

des added inline comments.Aug 7 2025, 10:55 PM
usr.bin/indent/tests/functional_test.sh
34–35

actually profile_flag was not local in the original code

des updated this revision to Diff 160013.Aug 7 2025, 10:59 PM

review feedback

Harbormaster completed remote builds in B66088: Diff 160013.Aug 7 2025, 10:59 PM
des updated this revision to Diff 160014.Aug 7 2025, 11:01 PM
des marked 2 inline comments as done.

oops

Harbormaster completed remote builds in B66089: Diff 160014.Aug 7 2025, 11:02 PM
markj accepted this revision as: markj.Aug 7 2025, 11:28 PM
markj added inline comments.
usr.bin/indent/tests/functional_test.sh
34–35

Ah, I was looking at profile_file.

This revision is now accepted and ready to land.Aug 7 2025, 11:28 PM
Closed by commit rG0ecc679fd3da: indent: Simplify test script (authored by des). · Explain WhyAug 7 2025, 11:37 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG0ecc679fd3da: indent: Simplify test script.
des added a commit: rG9bdd39b9fe52: indent: Simplify test script.Aug 14 2025, 4:04 PM
des added a commit: rG831799f6d3a9: indent: Simplify test script.

Revision Contents
Changeset List

PathSize
usr.bin/
indent/
tests/
55 lines

Diff 160017

View Options

usr.bin/indent/tests/functional_test.sh

Loading...