inotify: Avoid calling vrele() with a namecache mutex held

[markj]

Summary

In cache_vop_inotify(), we call inotify_log() with a namecache hash lock
held. inotify_log() looks at all watches registered with the vnode to
see if any of them are interested in the event. In some cases, we have
to detach and free the watch after logging the event. This means we
must vrele() the watched vnode, and this must not be done while a
non-sleepable lock held.

Previously, I deferred the vrele() to until the inotify softc and vnode
pollinfo locks were dropped. However, this is not enough since we may
still be holding the aforementioned namecache lock. Go further and use
a taskqueue thread to release vnode references. Introduce a set of
detached watches, and queue a threaded task which releases the vnode
reference.

Reported by: [e-mail]
Fixes: f1f230439fa4 ("vfs: Initial revision of inotify")

[kib]

sys/kern/vfs_inotify.c

172

Why this needs to be tree and not e.g. just a list?

[markj]

Use tailq linkage instead.