Page MenuHomeFreeBSD

[patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages
Needs ReviewPublic

Authored by mugius.0x101.freebsd_gmail.com on Feb 2 2016, 9:06 AM.

Details

Reviewers
s3erios_gmail.com
Group Reviewers
network
Summary

Update to PR206199

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mugius.0x101.freebsd_gmail.com retitled this revision from to [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages.
mugius.0x101.freebsd_gmail.com updated this object.
mugius.0x101.freebsd_gmail.com edited the test plan for this revision. (Show Details)
mugius.0x101.freebsd_gmail.com set the repository for this revision to rS FreeBSD src repository.

Hi!

Actually, the code tries to find a 'next' (fallback) rate, which will be used if transmission on the current rate fails; the code will be incorrect, when HT support will be added to the driver (but currently it should 'just work').

rix is the 'rate' index in ni->ni_rates.rs_rates table; since rates are sorted, the previous (or current if 'rix' is 0) should be fine as a fallback candidate.

bz added a subscriber: bz.Jan 7 2019, 3:20 PM

Depending on the outcome here, it look like bwi will need similar treatment?

bz added a comment.Jan 7 2019, 4:56 PM

Ok looks like bwi doesn't need.

I don't know too much about bwn(4).
Given we have hard coded mapping tables with a limited set of 'rates' according to bwn_hwrate2ieeerate() and bwn_ieeerate2hwrate() would it make sense to manually code a "one lower than this" table? I cannot see where we set the custom (limited) list of rates. bwn_addchannels() seems to add a lot more if I am not mistaken?

adrian added a subscriber: adrian.Jan 7 2019, 5:00 PM

Yeah, we should have a fallback rate function in net80211.

Why? Just to make sure that you're using the previously /negotiated/ rate, all the way back down to the lowest basic rate. Eg, you may not actually be allowed to use CCK 1Mbit rate according to the AP.

the atheros rate control code does this and it .. is wrong ;(