Differential D51646

kern: add a new ucred flag for groups having been set
ClosedPublic
Actions

Authored by kevans on Jul 31 2025, 5:00 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 11, 11:06 PM

	Unknown Object (File)
	Sat, Oct 11, 11:06 PM

	Unknown Object (File)
	Sat, Oct 11, 11:06 PM

	Unknown Object (File)
	Sat, Oct 11, 1:45 PM

	Unknown Object (File)
	Mon, Oct 6, 5:01 AM

	Unknown Object (File)
	Sep 13 2025, 2:44 AM

	Unknown Object (File)
	Sep 4 2025, 12:52 PM

	Unknown Object (File)
	Aug 19 2025, 2:19 PM

View All 26 Files

Subscribers

Details

Reviewers

Commits

rG09f2abaa59f9: kern: add a new ucred flag for groups having been set

Summary

Now that we can legitimately have ngroups == 0 as a result of calling
crsetgroups(), set a flag when we've set groups for the sake of sanity
checking usage of crextend(). While it's true this flag will only
really be used under INVARIANTS, it's only the second flag bit that
we're adding in 16 years.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Jul 31 2025, 5:00 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2025, 5:00 AM

kevans requested review of this revision.Jul 31 2025, 5:00 AM

Harbormaster completed remote builds in B65856: Diff 159482.Jul 31 2025, 5:00 AM

kevans added a child revision: D51647: kern: rename crsetgroups_fallback, document it in ucred(9).Jul 31 2025, 5:00 AM

olce accepted this revision.Jul 31 2025, 2:07 PM

This revision is now accepted and ready to land.Jul 31 2025, 2:07 PM

Closed by commit rG09f2abaa59f9: kern: add a new ucred flag for groups having been set (authored by kevans). · Explain WhyAug 1 2025, 12:51 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG09f2abaa59f9: kern: add a new ucred flag for groups having been set.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

1 line

1 line

kern/

15 lines

sys/

1 line

Diff 159523

sys/compat/linux/linux_misc.c

Loading...

sys/compat/linux/linux_uid16.c

Loading...

sys/kern/kern_prot.c

Loading...

sys/sys/ucred.h

Loading...