I somehow ended up with a tree where make -V BRANCH and make -V REVISION were broken, resulting in a FreeBSD-base.conf with a broken repo URL. Check for BRANCH == RELEASE explicitly and emit a warning if BRANCH does not match an expected case.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This LGTM!
I wonder if anything else breaks due to an invalid BRANCH. It looks like usr.sbin/pkg/Makefile silently ignores an invalid branch and falls back to latest. I'm not sure if this behavior is intentional or not though.
I'll make sure to update the duplication of this logic in https://reviews.freebsd.org/D51516, unfortunately I don't think there's a way to avoid the duplication without rewriting the vm image build scripts to use bsdinstall.