Page MenuHomeFreeBSD

rc.d: Fix mountd service script.
ClosedPublic

Authored by des on Jul 23 2025, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 12:13 PM
Unknown Object (File)
Mon, Oct 13, 12:13 PM
Unknown Object (File)
Mon, Oct 13, 12:13 PM
Unknown Object (File)
Sun, Oct 12, 11:33 PM
Unknown Object (File)
Fri, Oct 3, 8:39 AM
Unknown Object (File)
Tue, Sep 30, 8:31 AM
Unknown Object (File)
Wed, Sep 24, 1:57 AM
Unknown Object (File)
Wed, Sep 17, 4:16 AM
Subscribers

Details

Summary

This script references variables beloning to the nfsd and zfs services,
therefore it needs to load their configurations.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jul 23 2025, 11:55 AM

I don't see a problem with this, but I am not conversant
with the rc scripting stuff.

All the variables used by mountd are set in /usr/src/libexec/rc/rc.conf
and will be updated by the system's /etc/rc.conf file(s).
As such, I thought the values for all those variables were available to
the script?

I'll resign as a reviewer, since I do not know the rc script stuff, although
I'll note the change looks fine to me.

load_rc_config always loads /etc/rc.conf but does not load everything under /etc/rc.conf.d, so if one service needs to inspect configuration variables belonging to another, it must explicitly load_rc_config that other service in case those variables are set in /etc/rc.conf.d.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 24 2025, 1:01 PM
This revision was automatically updated to reflect the committed changes.