nfs_commonsubs.c: Lock vp for server calls to nfsv4_fillattr()
AbandonedPublic
Actions

Authored by rmacklem on Jul 18 2025, 12:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 12:47 AM

	Unknown Object (File)
	Tue, Oct 14, 12:47 AM

	Unknown Object (File)
	Mon, Oct 13, 11:14 AM

	Unknown Object (File)
	Fri, Oct 3, 7:18 PM

	Unknown Object (File)
	Wed, Oct 1, 7:48 AM

	Unknown Object (File)
	Wed, Oct 1, 6:06 AM

	Unknown Object (File)
	Tue, Sep 30, 10:34 PM

	Unknown Object (File)
	Tue, Sep 30, 9:08 AM

View All 16 Files

Subscribers

imp

Details

Reviewers

kib
des

Summary

des@ reported a panic in the NFSv4 server, where
nfsv4_fillattr() did a VOP_PATHCONF() without having
"vp" locked. kib@ suggested D51398 to fix it.

This patch is similar, but puts the NFSVOPLOCK()
call in one place near the top of the function.

des@, please test.

Test Plan

I will be building a kernel with DEBUG_VFS_LOCKS
so that I can find out if there are any more of these
bugs. (Yes, I have just been building GENERIC. Bad me.)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rmacklem created this revision.Jul 18 2025, 12:38 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 18 2025, 12:38 AM

rmacklem requested review of this revision.Jul 18 2025, 12:38 AM

Don't bother with this one, it is broken.

I'll put up another patch once I have one that works.

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfs/

	nfs_commonsubs.c
	nfs_commonsubs.c.vvroot

41 lines

Diff 158719

View Options

sys/fs/nfs/nfs_commonsubs.c

nfs_commonsubs.c: Lock vp for server calls to nfsv4_fillattr()AbandonedPublicActions