usbmuxd: Update to commit hash 0b1b233
AbandonedPublic
Actions

Authored by aokblast on Tue, Jul 8, 9:35 AM.

Details

Reviewers

jhale
lwhsu

Summary

The update contains patch in f8be60c which is needed to make usb
tethering works again.
Also, one of the commit shows that the patch for CFLAGS doesn't needed
anymore.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 65354
Build 62237: arc lint + arc unit

Event Timeline

aokblast requested review of this revision.Tue, Jul 8, 9:35 AM

aokblast created this revision.

Harbormaster completed remote builds in B65265: Diff 158142.Tue, Jul 8, 9:35 AM

aokblast added a reviewer: jhale.Tue, Jul 8, 9:37 AM

lwhsu added a subscriber: lwhsu.Tue, Jul 8, 2:37 PM

lwhsu added inline comments.

comms/usbmuxd/Makefile
2–3	From example 14 of https://docs.freebsd.org/en/books/porters-handbook/makefiles/index.html , I think it should be `-66` ?

I confirm with this and D49431, iPhone tethering works again now.

This revision is now accepted and ready to land.Tue, Jul 8, 5:29 PM

lwhsu mentioned this in D49431: ipheth: add ncm support for rx.Tue, Jul 8, 5:30 PM

One thing is that https://reviews.freebsd.org/D50359 is needed to compile. I think it is MFCed to 14 but may needs to wait another release?

aokblast added a parent revision: D49431: ipheth: add ncm support for rx.Wed, Jul 9, 2:53 AM

Fix version tag

This revision now requires review to proceed.Fri, Jul 11, 10:37 AM

Harbormaster completed remote builds in B65354: Diff 158326.Fri, Jul 11, 10:37 AM

I was working on an update for the imobiledevice family before I even saw this. Could we test my patch instead? It includes a fix for the LIBUSB_SPEED_SUPER_PLUS enum in usbmuxd on older FreeBSD versions.
https://people.freebsd.org/~jhale/patches/0001-imobiledevice-Update-suite-to-lastest-versions.patch

emaste added a subscriber: emaste.Mon, Jul 14, 6:45 PM

I have tested on the tethering network and shows no problem. Also, your patch is definitely better. Thus, I close the patch.