aio: if there is at least one aio thread, hide an error from aio_init_aioinfo()
ClosedPublic
Actions

Authored by kib on Jul 7 2025, 2:37 PM.

Details

Reviewers

Commits

rG0c38e3dbbf6e: aio: if there is at least one aio thread, hide an error from aio_init_aioinfo()

Summary

Noted by:       jhb
Fixes:  4685fa8e4bef169e6a1ceaf07f149232326de805

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jul 7 2025, 2:37 PM

Herald added subscribers: olce, imp. · View Herald TranscriptJul 7 2025, 2:37 PM

kib requested review of this revision.Jul 7 2025, 2:37 PM

Note that if fork() fails, then the process is already in somewhat funny state. In the case that was reported by pho and which caused the referenced change, the mechanism preventing the forked child to escape group signal was kicking, and the process was going to terminate (loop prevented the single-threading in exit). So we are already not healthy if an error occured.

On the other hand, if there is just one aio worker, then aio is not too functional.

Anyway, I think the patch should be the right thing.

Add comment.

jhb accepted this revision.Jul 7 2025, 5:08 PM

This revision is now accepted and ready to land.Jul 7 2025, 5:08 PM

Closed by commit rG0c38e3dbbf6e: aio: if there is at least one aio thread, hide an error from aio_init_aioinfo() (authored by kib). · Explain WhyJul 7 2025, 5:53 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG0c38e3dbbf6e: aio: if there is at least one aio thread, hide an error from aio_init_aioinfo().