md(4): move type-specific data under union
ClosedPublic
Actions

Authored by kib on Jul 2 2025, 1:14 PM.

Details

Reviewers

markj

Commits

rGe91022168101: md(4): move type-specific data under union

Summary

This way it is clear which type uses which members.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jul 2 2025, 1:14 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 2 2025, 1:14 PM

kib requested review of this revision.Jul 2 2025, 1:14 PM

kib added a child revision: D51128: md(4): add support for unmapped preloaded images.

kib added a reviewer: markj.Jul 2 2025, 1:19 PM

markj added inline comments.Jul 2 2025, 1:31 PM

sys/dev/md/md.c
279	Isn't it ok to use anonymous unions in kernel code?
1577	Shouldn't we handle MD_PRELOAD here too? It looks like that case is reachable.

kib marked 2 inline comments as done.Jul 2 2025, 2:05 PM

kib added inline comments.

sys/dev/md/md.c
279	I removed 's', but the names of the structure members is the point of the commit.

Drop internal union member name.
Handle MD_PRELOAD in mddestroy().

kib mentioned this in D51128: md(4): add support for unmapped preloaded images.Jul 2 2025, 2:07 PM

Correct diff, with all 's.' eliminated.

markj accepted this revision.Jul 2 2025, 2:24 PM

markj added inline comments.

sys/dev/md/md.c
279	Right, I just meant that the `s` didn't seem useful.

This revision is now accepted and ready to land.Jul 2 2025, 2:24 PM

Closed by commit rGe91022168101: md(4): move type-specific data under union (authored by kib). · Explain WhyJul 2 2025, 3:33 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGe91022168101: md(4): move type-specific data under union.

Revision Contents
Changeset List

Path

Size

sys/

dev/

md/

md.c

263 lines

Diff 157848

View Options

md(4): move type-specific data under unionClosedPublicActions