Page MenuHomeFreeBSD

libbsnmp: make snmp_parse_server() more robust when lacking info
ClosedPublic

Authored by glebius on Jun 26 2025, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 10, 3:36 AM
Unknown Object (File)
Fri, Nov 7, 11:24 PM
Unknown Object (File)
Thu, Nov 6, 7:02 PM
Unknown Object (File)
Wed, Nov 5, 2:34 AM
Unknown Object (File)
Mon, Nov 3, 7:03 AM
Unknown Object (File)
Sun, Nov 2, 8:35 AM
Unknown Object (File)
Sun, Oct 26, 7:57 PM
Unknown Object (File)
Sat, Oct 25, 7:29 PM
Subscribers

Details

Summary

Per documentation snmp_parse_server() has all 4 components optional. We
want inputs like "udp::", "udp6::", "stream::" work with local default
sockets and even degenerate case of "" shall end with defaults instead of
a failure.

While here make the parser more robust. Make all parser helpers to behave
the same way: on successful return they are responsible to update both
start & end of matched substring and return next characater to parse.
This eliminates special handling of IPv6 and port parser that used to need
to skip a character, and thus eliminates unchecked step forward in
snmp_parse_server() itself. Additionally:

  • use strchr(3) instead of own cycle
  • INET_ADDRSTRLEN includes space for NUL character
  • INET6_ADDRSTRLEN includes both the scope and NUL character
  • prefer sizeof() comparison instead of preprocessor define repetitive use

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable