Page MenuHomeFreeBSD

libbsnmp: make snmp_parse_server() more robust when lacking info
ClosedPublic

Authored by glebius on Jun 26 2025, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 15, 4:27 AM
Unknown Object (File)
Sat, Jan 31, 2:42 AM
Unknown Object (File)
Tue, Jan 20, 8:51 PM
Unknown Object (File)
Jan 15 2026, 11:39 PM
Unknown Object (File)
Jan 15 2026, 7:08 PM
Unknown Object (File)
Jan 6 2026, 6:04 AM
Unknown Object (File)
Nov 10 2025, 3:36 AM
Unknown Object (File)
Nov 7 2025, 11:24 PM
Subscribers

Details

Summary

Per documentation snmp_parse_server() has all 4 components optional. We
want inputs like "udp::", "udp6::", "stream::" work with local default
sockets and even degenerate case of "" shall end with defaults instead of
a failure.

While here make the parser more robust. Make all parser helpers to behave
the same way: on successful return they are responsible to update both
start & end of matched substring and return next characater to parse.
This eliminates special handling of IPv6 and port parser that used to need
to skip a character, and thus eliminates unchecked step forward in
snmp_parse_server() itself. Additionally:

  • use strchr(3) instead of own cycle
  • INET_ADDRSTRLEN includes space for NUL character
  • INET6_ADDRSTRLEN includes both the scope and NUL character
  • prefer sizeof() comparison instead of preprocessor define repetitive use

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable