Page MenuHomeFreeBSD

libbsnmp: make snmp_parse_server() more robust when lacking info
ClosedPublic

Authored by glebius on Jun 26 2025, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 1:44 AM
Unknown Object (File)
Tue, Oct 14, 1:44 AM
Unknown Object (File)
Tue, Oct 14, 1:43 AM
Unknown Object (File)
Mon, Oct 13, 12:11 PM
Unknown Object (File)
Thu, Oct 9, 11:22 PM
Unknown Object (File)
Sep 16 2025, 11:41 PM
Unknown Object (File)
Sep 14 2025, 8:09 AM
Unknown Object (File)
Sep 14 2025, 7:25 AM
Subscribers

Details

Summary

Per documentation snmp_parse_server() has all 4 components optional. We
want inputs like "udp::", "udp6::", "stream::" work with local default
sockets and even degenerate case of "" shall end with defaults instead of
a failure.

While here make the parser more robust. Make all parser helpers to behave
the same way: on successful return they are responsible to update both
start & end of matched substring and return next characater to parse.
This eliminates special handling of IPv6 and port parser that used to need
to skip a character, and thus eliminates unchecked step forward in
snmp_parse_server() itself. Additionally:

  • use strchr(3) instead of own cycle
  • INET_ADDRSTRLEN includes space for NUL character
  • INET6_ADDRSTRLEN includes both the scope and NUL character
  • prefer sizeof() comparison instead of preprocessor define repetitive use

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable