Page MenuHomeFreeBSD
Differential D5094

Fixing kbd.c bug 'OGIO_KEYMAP command does not restore priority level'
AbandonedPublic
Actions

Authored by mmokhi on Jan 27 2016, 5:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 1:26 PM
Unknown Object (File)
Feb 14 2024, 8:23 PM
Unknown Object (File)
Jan 3 2024, 8:37 AM
Unknown Object (File)
Dec 23 2023, 4:55 PM
Unknown Object (File)
Nov 10 2023, 6:32 PM
Unknown Object (File)
Nov 8 2023, 6:36 PM
Unknown Object (File)
Nov 6 2023, 3:37 PM
Unknown Object (File)
Nov 4 2023, 9:36 PM
View All 41 Files
Subscribers
andrew
emaste
imp
mmokhi
Contributor Reviews (src)

Details

Reviewers
gnn
Summary

Missing call of 'splx()' before return inside 'genkbd_commonioctl()'

May cause security vuln. (thanks to CTurt@hardenedbsd )

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2293
Build 2302: arc lint + arc unit

Event Timeline

mmokhi updated this revision to Diff 12767.Jan 27 2016, 5:52 PM
mmokhi retitled this revision from to Fixing kbd.c bug 'OGIO_KEYMAP command does not restore priority level'.
mmokhi updated this object.
mmokhi edited the test plan for this revision. (Show Details)
mmokhi added a subscriber: mmokhi.
Herald added a reviewer: gnn. · View Herald TranscriptJan 27 2016, 5:52 PM
Herald added subscribers: Contributor Reviews (src), emaste, andrew, imp. · View Herald Transcript
mmokhi added a comment.Jan 27 2016, 5:55 PM

It's worng reveision, opened by my fault, sorry :(

mmokhi added a comment.Jan 27 2016, 6:02 PM

i don't know how to close it.
please close it, when you saw it.

sorry

mmokhi planned changes to this revision.Jan 27 2016, 6:19 PM
mmokhi abandoned this revision.

Large Diff

This large diff affects 240 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
cddl/
contrib/
dtracetoolkit/
Bin/
76 lines
82 lines
179 lines
185 lines
204 lines
67 lines
73 lines
182 lines
11 lines
75 lines
240 lines
260 lines
548 lines
114 lines
53 lines
69 lines
93 lines
163 lines
465 lines
251 lines
181 lines
168 lines
117 lines
11 lines
155 lines
150 lines
119 lines
126 lines
72 lines
140 lines
133 lines
62 lines
50 lines
67 lines
74 lines
80 lines
60 lines
278 lines
262 lines
368 lines
423 lines
117 lines
114 lines
130 lines
101 lines
117 lines
130 lines
57 lines
88 lines
102 lines
61 lines
62 lines
57 lines
79 lines
149 lines
69 lines
136 lines
65 lines
59 lines
102 lines
77 lines
116 lines
102 lines
116 lines
52 lines
70 lines
87 lines
85 lines
62 lines
90 lines
56 lines
121 lines
57 lines
64 lines
67 lines
91 lines
59 lines
11 lines
11 lines
58 lines
11 lines
63 lines
11 lines
11 lines
103 lines
245 lines
101 lines
283 lines
54 lines
11 lines
84 lines
91 lines
84 lines
91 lines
73 lines
89 lines
92 lines
57 lines
83 lines
76 lines
117 lines
57 lines
58 lines
83 lines
90 lines
83 lines
90 lines
71 lines
87 lines
89 lines
82 lines
56 lines
66 lines
120 lines
57 lines
68 lines
67 lines
234 lines
39 lines
83 lines
90 lines
83 lines
90 lines
71 lines
87 lines
90 lines
56 lines
82 lines
50 lines
80 lines
64 lines
117 lines
57 lines
121 lines
88 lines
130 lines
121 lines
130 lines
73 lines
89 lines
85 lines
58 lines
56 lines
81 lines
62 lines
56 lines
147 lines
67 lines
134 lines
57 lines
11 lines
11 lines
92 lines
99 lines
57 lines
62 lines
62 lines
102 lines
234 lines
293 lines
106 lines
102 lines
86 lines
83 lines
120 lines
73 lines
137 lines
143 lines
159 lines
86 lines
153 lines
119 lines
56 lines
204 lines
134 lines
84 lines
170 lines
102 lines
57 lines
265 lines
119 lines
62 lines
96 lines
287 lines
150 lines
54 lines
55 lines
11 lines
11 lines
112 lines
64 lines
124 lines
112 lines
124 lines
87 lines
106 lines
58 lines
124 lines
54 lines
71 lines
138 lines
67 lines
140 lines
63 lines
582 lines
425 lines
584 lines
427 lines
92 lines
580 lines
582 lines
83 lines
67 lines
185 lines
122 lines
93 lines
54 lines
55 lines
156 lines
138 lines
305 lines
187 lines
80 lines
64 lines
144 lines
11 lines
11 lines
52 lines
218 lines
278 lines
Docs/
153 lines
Examples/
42 lines
62 lines
29 lines
92 lines
sys/
boot/
fdt/
dts/
arm/
432 lines
dev/
kbd/
2 lines

Diff 12767

View Options

cddl/contrib/dtracetoolkit/Bin/anonpgpid.d

View Options

cddl/contrib/dtracetoolkit/Bin/bitesize.d

View Options

cddl/contrib/dtracetoolkit/Bin/connections

View Options

cddl/contrib/dtracetoolkit/Bin/cpudists

View Options

cddl/contrib/dtracetoolkit/Bin/cputimes

View Options

cddl/contrib/dtracetoolkit/Bin/cputypes.d

View Options

cddl/contrib/dtracetoolkit/Bin/cpuwalk.d

View Options

cddl/contrib/dtracetoolkit/Bin/crash.d

View Options

cddl/contrib/dtracetoolkit/Bin/creatbyproc.d

View Options

cddl/contrib/dtracetoolkit/Bin/cswstat.d

View Options

cddl/contrib/dtracetoolkit/Bin/dappprof

View Options

cddl/contrib/dtracetoolkit/Bin/dapptrace

View Options

cddl/contrib/dtracetoolkit/Bin/dexplorer

View Options

cddl/contrib/dtracetoolkit/Bin/diskhits

View Options

cddl/contrib/dtracetoolkit/Bin/dispqlen.d

View Options

cddl/contrib/dtracetoolkit/Bin/dnlcps.d

View Options

cddl/contrib/dtracetoolkit/Bin/dnlcsnoop.d

View Options

cddl/contrib/dtracetoolkit/Bin/dnlcstat

View Options

cddl/contrib/dtracetoolkit/Bin/dtruss

View Options

cddl/contrib/dtracetoolkit/Bin/dvmstat

View Options

cddl/contrib/dtracetoolkit/Bin/errinfo

View Options

cddl/contrib/dtracetoolkit/Bin/execsnoop

View Options

cddl/contrib/dtracetoolkit/Bin/fddist

View Options

cddl/contrib/dtracetoolkit/Bin/filebyproc.d

View Options

cddl/contrib/dtracetoolkit/Bin/fspaging.d

View Options

cddl/contrib/dtracetoolkit/Bin/fsrw.d

View Options

cddl/contrib/dtracetoolkit/Bin/guess.d

View Options

cddl/contrib/dtracetoolkit/Bin/hotkernel

View Options

cddl/contrib/dtracetoolkit/Bin/hotspot.d

View Options

cddl/contrib/dtracetoolkit/Bin/hotuser

View Options

cddl/contrib/dtracetoolkit/Bin/httpdstat.d

View Options

cddl/contrib/dtracetoolkit/Bin/icmpstat.d

View Options

cddl/contrib/dtracetoolkit/Bin/intbycpu.d

View Options

cddl/contrib/dtracetoolkit/Bin/intoncpu.d

View Options

cddl/contrib/dtracetoolkit/Bin/inttimes.d

View Options

cddl/contrib/dtracetoolkit/Bin/iofile.d

View Options

cddl/contrib/dtracetoolkit/Bin/iofileb.d

View Options

cddl/contrib/dtracetoolkit/Bin/iopattern

View Options

cddl/contrib/dtracetoolkit/Bin/iopending

View Options

cddl/contrib/dtracetoolkit/Bin/iosnoop

View Options

cddl/contrib/dtracetoolkit/Bin/iotop

View Options

cddl/contrib/dtracetoolkit/Bin/j_calldist.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_calls.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_calltime.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_classflow.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_cpudist.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_cputime.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_events.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_flow.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_flowtime.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_methodcalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_objnew.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_package.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_profile.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_stat.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_syscalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_syscolors.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_thread.d

View Options

cddl/contrib/dtracetoolkit/Bin/j_who.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_calldist.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_calls.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_calltime.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_cpudist.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_cputime.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_execs.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_flow.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_flowinfo.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_flowtime.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_objcpu.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_objgc.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_objnew.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_stat.d

View Options

cddl/contrib/dtracetoolkit/Bin/js_who.d

View Options

cddl/contrib/dtracetoolkit/Bin/kill.d

View Options

cddl/contrib/dtracetoolkit/Bin/kstat_types.d

View Options

cddl/contrib/dtracetoolkit/Bin/lastwords

View Options

cddl/contrib/dtracetoolkit/Bin/loads.d

View Options

cddl/contrib/dtracetoolkit/Bin/lockbydist.d

View Options

cddl/contrib/dtracetoolkit/Bin/lockbyproc.d

View Options

cddl/contrib/dtracetoolkit/Bin/minfbypid.d

View Options

cddl/contrib/dtracetoolkit/Bin/minfbyproc.d

View Options

cddl/contrib/dtracetoolkit/Bin/mmapfiles.d

View Options

cddl/contrib/dtracetoolkit/Bin/modcalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/newproc.d

View Options

cddl/contrib/dtracetoolkit/Bin/nfswizard.d

View Options

cddl/contrib/dtracetoolkit/Bin/opensnoop

View Options

cddl/contrib/dtracetoolkit/Bin/pathopens.d

View Options

cddl/contrib/dtracetoolkit/Bin/pfilestat

View Options

cddl/contrib/dtracetoolkit/Bin/pgpginbypid.d

View Options

cddl/contrib/dtracetoolkit/Bin/pgpginbyproc.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_calldist.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_calltime.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_cpudist.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_cputime.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_flow.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_flowinfo.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_flowtime.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_funccalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_malloc.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_syscalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_syscolors.d

View Options

cddl/contrib/dtracetoolkit/Bin/php_who.d

View Options

cddl/contrib/dtracetoolkit/Bin/pidpersec.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_calldist.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_calltime.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_cpudist.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_cputime.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_flow.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_flowinfo.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_flowtime.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_malloc.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_subcalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_syscalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_syscolors.d

View Options

cddl/contrib/dtracetoolkit/Bin/pl_who.d

View Options

cddl/contrib/dtracetoolkit/Bin/priclass.d

View Options

cddl/contrib/dtracetoolkit/Bin/pridist.d

View Options

cddl/contrib/dtracetoolkit/Bin/procsystime

View Options

cddl/contrib/dtracetoolkit/Bin/putnexts.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_calldist.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_calltime.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_cpudist.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_cputime.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_flow.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_flowinfo.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_flowtime.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_funccalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_malloc.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_mallocstk.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_profile.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_syscalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_syscolors.d

View Options

cddl/contrib/dtracetoolkit/Bin/py_who.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_calldist.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_calls.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_calltime.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_cpudist.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_cputime.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_flow.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_flowinfo.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_flowtime.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_funccalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_lines.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_malloc.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_objcpu.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_objnew.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_stat.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_syscalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_syscolors.d

View Options

cddl/contrib/dtracetoolkit/Bin/rb_who.d

View Options

cddl/contrib/dtracetoolkit/Bin/readbytes.d

View Options

cddl/contrib/dtracetoolkit/Bin/readdist.d

View Options

cddl/contrib/dtracetoolkit/Bin/rfileio.d

View Options

cddl/contrib/dtracetoolkit/Bin/rfsio.d

View Options

cddl/contrib/dtracetoolkit/Bin/runocc.d

View Options

cddl/contrib/dtracetoolkit/Bin/rwbbypid.d

View Options

cddl/contrib/dtracetoolkit/Bin/rwbypid.d

View Options

cddl/contrib/dtracetoolkit/Bin/rwbytype.d

View Options

cddl/contrib/dtracetoolkit/Bin/rwsnoop

View Options

cddl/contrib/dtracetoolkit/Bin/rwtop

View Options

cddl/contrib/dtracetoolkit/Bin/sampleproc

View Options

cddl/contrib/dtracetoolkit/Bin/sar-c.d

View Options

cddl/contrib/dtracetoolkit/Bin/seeksize.d

View Options

cddl/contrib/dtracetoolkit/Bin/setuids.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_calldist.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_calls.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_calltime.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_cpudist.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_cputime.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_flow.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_flowinfo.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_flowtime.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_lines.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_pidcolors.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_stat.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_syscalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_syscolors.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_wasted.d

View Options

cddl/contrib/dtracetoolkit/Bin/sh_who.d

View Options

cddl/contrib/dtracetoolkit/Bin/shellsnoop

View Options

cddl/contrib/dtracetoolkit/Bin/shortlived.d

View Options

cddl/contrib/dtracetoolkit/Bin/sigdist.d

View Options

cddl/contrib/dtracetoolkit/Bin/stacksize.d

View Options

cddl/contrib/dtracetoolkit/Bin/statsnoop

View Options

cddl/contrib/dtracetoolkit/Bin/swapinfo.d

View Options

cddl/contrib/dtracetoolkit/Bin/sysbypid.d

View Options

cddl/contrib/dtracetoolkit/Bin/syscallbypid.d

View Options

cddl/contrib/dtracetoolkit/Bin/syscallbyproc.d

View Options

cddl/contrib/dtracetoolkit/Bin/syscallbysysc.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_calldist.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_calls.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_calltime.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_cpudist.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_cputime.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_flow.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_flowtime.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_ins.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_insflow.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_proccalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_procflow.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_stat.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_syscalls.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_syscolors.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcl_who.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcpsnoop

View Options

cddl/contrib/dtracetoolkit/Bin/tcpsnoop.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcpsnoop_snv

View Options

cddl/contrib/dtracetoolkit/Bin/tcpsnoop_snv.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcpstat.d

View Options

cddl/contrib/dtracetoolkit/Bin/tcptop

View Options

cddl/contrib/dtracetoolkit/Bin/tcptop_snv

View Options

cddl/contrib/dtracetoolkit/Bin/tcpwdist.d

View Options

cddl/contrib/dtracetoolkit/Bin/threaded.d

View Options

cddl/contrib/dtracetoolkit/Bin/topsyscall

View Options

cddl/contrib/dtracetoolkit/Bin/topsysproc

View Options

cddl/contrib/dtracetoolkit/Bin/udpstat.d

View Options

cddl/contrib/dtracetoolkit/Bin/uname-a.d

View Options

cddl/contrib/dtracetoolkit/Bin/vmbypid.d

View Options

cddl/contrib/dtracetoolkit/Bin/vmstat-p.d

View Options

cddl/contrib/dtracetoolkit/Bin/vmstat.d

View Options

cddl/contrib/dtracetoolkit/Bin/vopstat

View Options

cddl/contrib/dtracetoolkit/Bin/weblatency.d

View Options

cddl/contrib/dtracetoolkit/Bin/whatexec.d

View Options

cddl/contrib/dtracetoolkit/Bin/woof.d

View Options

cddl/contrib/dtracetoolkit/Bin/wpm.d

View Options

cddl/contrib/dtracetoolkit/Bin/writebytes.d

View Options

cddl/contrib/dtracetoolkit/Bin/writedist.d

View Options

cddl/contrib/dtracetoolkit/Bin/xcallsbypid.d

View Options

cddl/contrib/dtracetoolkit/Bin/xvmstat

View Options

cddl/contrib/dtracetoolkit/Bin/zvmstat

View Options

cddl/contrib/dtracetoolkit/Docs/Examples/

View Options

cddl/contrib/dtracetoolkit/Docs/Index

View Options

cddl/contrib/dtracetoolkit/Docs/Notes/

View Options

cddl/contrib/dtracetoolkit/Examples/tcpsnoop_snv_d_example.txt

View Options

cddl/contrib/dtracetoolkit/Examples/tcpsnoop_snv_example.txt

View Options

cddl/contrib/dtracetoolkit/Examples/tcptop_snv_example.txt

View Options

cddl/contrib/dtracetoolkit/License

View Options

cddl/contrib/dtracetoolkit/README

View Options

sys/boot/fdt/dts/arm/zybo.dts

View Options

sys/dev/kbd/kbd.c