Goal is to avoid having to include the full <sys/param.h> just to get
some common useful macros. More macros should be moved into it as
needed.
This is in preparation for using NBBY and howmany() from <sys/runq.h>.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/sys/param.h | ||
|---|---|---|
| 322 | ||
| sys/sys/_param.h | ||
|---|---|---|
| 10 | Maybe we should start using #pragma once? | |
| sys/sys/_param.h | ||
|---|---|---|
| 10 | I generally am for it. There are some caveats in using it (reminded in this unrelated C++ proposal) but they don't seem to apply here. Changed in my local copy. | |
| sys/sys/_param.h | ||
|---|---|---|
| 10 | This feature is not even in C23. IMO this would be a gratuitous dependency on the compiler extension which could be avoided. The argument that our system needs gcc-like compiler anyway does not apply there, the header is used by third-party code. There are enough small C compilers like tcc and other, which we should aim to support. | |
| sys/sys/_param.h | ||
|---|---|---|
| 10 | Yes, I'm aware that this feature is completely non-standard. But it has been supported for so long by GCC that I thought it had percolated to basically every C compiler still in existence. I'll just back out introducing #pragma once to be safe, and we can see to intrducing #pragma once later. For reference, according to GCC documentation, #pragma once existed in GCC 2.95 at least, was marked obsolete until GCC 9 since when the manual has been mentioning it again in the front "Pragmas" page. | |
| sys/sys/_param.h | ||
|---|---|---|
| 10 | We already gratuitously depend on boatloads of non-standard features... #pragma once is used elsewhere in the tree... But only in openssl and 3 debug .h files... Tinyc supports this since Linux uses it all over the place.... But I don't feel strongly enough about it to do more than ask the question... I'm good either way | |