Do not destroy input buffer of the OF_getencprop() function on error
ClosedPublic
Actions

Authored by zbb on Jan 25 2016, 12:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 12, 1:10 PM

	Unknown Object (File)
	Wed, Nov 12, 1:10 PM

	Unknown Object (File)
	Wed, Nov 12, 9:34 AM

	Unknown Object (File)
	Tue, Nov 4, 1:34 AM

	Unknown Object (File)
	Sat, Oct 25, 9:13 AM

	Unknown Object (File)
	Sun, Oct 19, 4:18 PM

	Unknown Object (File)
	Fri, Oct 17, 3:47 PM

	Unknown Object (File)
	Oct 14 2025, 5:22 AM

Subscribers

Details

Reviewers

mmel
• ian

Summary

Currently when the OF_getprop() function returns with error,
the caller (OF_getencprop()) still changes the buffer endiannes.
This may destroy the default value passed in the input buffer if
used on a Little Endian platform.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zbb updated this revision to Diff 12680.Jan 25 2016, 12:31 PM

zbb retitled this revision from to Do not destroy input buffer of the OF_getencprop() function on error.

zbb updated this object.

zbb edited the test plan for this revision. (Show Details)

zbb added a reviewer: • ian.

zbb set the repository for this revision to rS FreeBSD src repository - subversion.

zbb added subscribers: ARM, PowerPC.

Herald added a subscriber: imp. · View Herald TranscriptJan 25 2016, 12:31 PM

mmel accepted this revision.Jan 25 2016, 12:33 PM

mmel added a reviewer: mmel.

This revision is now accepted and ready to land.Jan 25 2016, 12:33 PM

Committed to r294729

Revision Contents
Changeset List

Path

Size

sys/

dev/

ofw/

openfirm.c

3 lines

Diff 12680

View Options

Do not destroy input buffer of the OF_getencprop() function on errorClosedPublicActions