devfs: Set eofflag in devfs_readdir()
ClosedPublic
Actions

Authored by markj on May 29 2025, 2:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 29, 10:41 PM

	Unknown Object (File)
	Wed, Sep 17, 5:05 PM

	Unknown Object (File)
	Wed, Sep 17, 10:38 AM

	Unknown Object (File)
	Wed, Sep 17, 8:21 AM

	Unknown Object (File)
	Sep 12 2025, 4:34 AM

	Unknown Object (File)
	Aug 30 2025, 11:44 AM

	Unknown Object (File)
	Aug 29 2025, 5:28 PM

	Unknown Object (File)
	Aug 20 2025, 9:02 PM

View All 38 Files

Subscribers

imp

Details

Reviewers

kib
olce

Commits

rG0d698e74fb6b: devfs: Set eofflag in devfs_readdir()
rG198d2ed2d4c6: devfs: Set eofflag in devfs_readdir()

Summary

At least vn_dir_next_dirent() checks that eofflag is set appropriately
when INVARIANTS is enabled, so the omission here could cause an
assertion failure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 29 2025, 2:50 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 29 2025, 2:50 PM

markj requested review of this revision.May 29 2025, 2:50 PM

Harbormaster completed remote builds in B64530: Diff 156254.May 29 2025, 2:51 PM

kib accepted this revision.May 29 2025, 2:53 PM

kib added inline comments.

sys/fs/devfs/devfs_vnops.c
1518

This revision is now accepted and ready to land.May 29 2025, 2:53 PM

markj marked an inline comment as done.May 29 2025, 2:58 PM

Closed by commit rG198d2ed2d4c6: devfs: Set eofflag in devfs_readdir() (authored by markj). · Explain WhyMay 29 2025, 6:28 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG198d2ed2d4c6: devfs: Set eofflag in devfs_readdir().

markj added a commit: rG0d698e74fb6b: devfs: Set eofflag in devfs_readdir().Jun 20 2025, 1:53 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

devfs/

devfs_vnops.c

2 lines

Diff 156269

View Options

sys/fs/devfs/devfs_vnops.c

devfs: Set eofflag in devfs_readdir()ClosedPublicActions