devfs: Set eofflag in devfs_readdir()
ClosedPublic
Actions

Authored by markj on Thu, May 29, 2:50 PM.

Details

Reviewers

kib
olce

Commits

rG198d2ed2d4c6: devfs: Set eofflag in devfs_readdir()

Summary

At least vn_dir_next_dirent() checks that eofflag is set appropriately
when INVARIANTS is enabled, so the omission here could cause an
assertion failure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Thu, May 29, 2:50 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, May 29, 2:50 PM

markj requested review of this revision.Thu, May 29, 2:50 PM

Harbormaster completed remote builds in B64530: Diff 156254.Thu, May 29, 2:51 PM

kib accepted this revision.Thu, May 29, 2:53 PM

kib added inline comments.

sys/fs/devfs/devfs_vnops.c
1518

This revision is now accepted and ready to land.Thu, May 29, 2:53 PM

markj marked an inline comment as done.Thu, May 29, 2:58 PM

Closed by commit rG198d2ed2d4c6: devfs: Set eofflag in devfs_readdir() (authored by markj). · Explain WhyThu, May 29, 6:28 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG198d2ed2d4c6: devfs: Set eofflag in devfs_readdir().

Revision Contents
Changeset List

Path

Size

sys/

fs/

devfs/

devfs_vnops.c

2 lines

Diff 156269

View Options

sys/fs/devfs/devfs_vnops.c

devfs: Set eofflag in devfs_readdir()ClosedPublicActions