glob: Add tests for error callback functions and blocks
ClosedPublic
Actions

Authored by bnovkov on May 23 2025, 2:39 PM.

Details

Reviewers

des

Group Reviewers

Klara

Commits

rG4d7c31bca252: glob2_test: Add tests for error callback functions and blocks

Summary

This change adds tests that check basic callback functionality for
blocks and function pointers. The tests also make sure that GLOB_ERR
overrides the callback's return value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bnovkov created this revision.May 23 2025, 2:39 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2025, 2:39 PM

bnovkov requested review of this revision.May 23 2025, 2:39 PM

Harbormaster completed remote builds in B64377: Diff 155919.May 23 2025, 2:39 PM

bnovkov added a parent revision: D50485: glob: Add blocks support.May 23 2025, 2:39 PM

Add test for matching files that start with a period

des requested changes to this revision.May 26 2025, 3:40 PM

des added a subscriber: des.

des added inline comments.

lib/libc/tests/gen/Makefile
17–20	This now needs to be conditional on `${COMPILER_FEATURES:Mblocks}`, which means that if built with gcc, we don't test `glob(3)` at all, so perhaps the block-specific tests should go in a separate `glob_blocks_test`.
lib/libc/tests/gen/glob2_test.c
30

This revision now requires changes to proceed.May 26 2025, 3:40 PM

bnovkov updated this revision to Diff 156084.May 27 2025, 10:01 AM

bnovkov retitled this revision from glob2_test: Add tests for error callback functions and blocks to glob: Add tests for error callback functions and blocks.

bnovkov marked 2 inline comments as done.

bnovkov added inline comments.