libc: nfsv4 acls: flip 'd' and 'D' in table definitions
Needs ReviewPublic
Actions

Authored by kevans on May 8 2025, 7:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 26, 11:36 PM

	Unknown Object (File)
	Fri, Nov 21, 10:44 PM

	Unknown Object (File)
	Fri, Nov 14, 8:52 PM

	Unknown Object (File)
	Wed, Nov 5, 8:37 PM

	Unknown Object (File)
	Wed, Nov 5, 7:40 PM

	Unknown Object (File)
	Mon, Nov 3, 4:41 PM

	Unknown Object (File)
	Mon, Nov 3, 2:26 PM

	Unknown Object (File)
	Sun, Nov 2, 9:26 AM

View All 50 Files

Subscribers

imp

Details

Reviewers

emaste
trasz
walker.aj325_gmail.com

Summary

In theory this fixes the ordering for getfacl(1) to match what Illumos
and some other systems use, which has some benefits when trying to use
output from it in their tooling. FreeBSD's setfacl(1) doesn't seem to
do positional bits, so this change seems like it's both safe and likely
to improve interoperability.

PR: 286669
"Why not?": emaste

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64014
Build 60898: arc lint + arc unit

Event Timeline

kevans created this revision.May 8 2025, 7:19 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 8 2025, 7:19 PM

kevans requested review of this revision.May 8 2025, 7:19 PM

Harbormaster completed remote builds in B64014: Diff 155159.May 8 2025, 7:19 PM

Need to fix the title... should've mentioned NFSv4 ACLs. *sigh*

kevans retitled this revision from libc: flip 'd' and 'D' in nfs4 acl definitions to libc: nfsv4 acls: flip 'd' and 'D' in table definitions.May 8 2025, 7:20 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

posix1e/

acl_support_nfs4.c

2 lines

Diff 155159

View Options

lib/libc/posix1e/acl_support_nfs4.c

libc: nfsv4 acls: flip 'd' and 'D' in table definitionsNeeds ReviewPublicActions