LinuxKPI: sysfs: use a sysctl_ctx_list
Needs ReviewPublic
Actions

Authored by bz on May 4 2025, 10:08 PM.

Tags

None

Referenced Files

	F160195873: D50155.diff
	Mon, Jun 22, 2:11 AM

	Unknown Object (File)
	Sun, Jun 14, 11:34 PM

	Unknown Object (File)
	Tue, Jun 9, 1:26 PM

	Unknown Object (File)
	Wed, Jun 3, 7:44 PM

	Unknown Object (File)
	Tue, Jun 2, 10:55 AM

	Unknown Object (File)
	Sat, May 30, 2:04 PM

	Unknown Object (File)
	Fri, May 29, 8:58 PM

	Unknown Object (File)
	Thu, May 28, 10:19 AM

View All 53 Files

Subscribers

emaste

imp

Details

Reviewers

None

Group Reviewers

linuxkpi

Summary

While sysctl_remove_oid() may recusrively try to delete all
sysctl nodes, if one is still referenced it may panic (bd3cdc3105aae).
Use a sysctl_ctx_list to nicely group them all together
and also to release them -- at beast -- with a leak.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

Just putting this out. Still not sure it's the best idea and
fully correct. Done while debugging some other crashes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 63879
Build 60763: arc lint + arc unit

Event Timeline

bz created this revision.May 4 2025, 10:08 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMay 4 2025, 10:08 PM

bz requested review of this revision.May 4 2025, 10:08 PM

Harbormaster completed remote builds in B63879: Diff 154811.May 4 2025, 10:08 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

kobject.h

1 line

sysfs.h

48 lines

Diff 154811

View Options

sys/compat/linuxkpi/common/include/linux/kobject.h