Page MenuHomeFreeBSD

LinuxKPI: pci: deal with kobject_add() being able to fail
ClosedPublic

Authored by bz on May 4 2025, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 12:59 AM
Unknown Object (File)
Fri, Sep 11, 12:31 AM
Unknown Object (File)
Thu, Sep 10, 2:30 PM
Unknown Object (File)
Sun, Sep 6, 11:44 AM
Unknown Object (File)
Sun, Sep 6, 10:39 AM
Unknown Object (File)
Sun, Sep 6, 9:52 AM
Unknown Object (File)
Sat, Sep 5, 6:08 PM
Unknown Object (File)
Sat, Sep 5, 10:39 AM
Subscribers

Details

Summary

lkpifill_pci_dev() uses a sequene of kobject_init/set_name/add.
The problem is that kobject_add could fail.

Move the entire logic to the beginning of the function,
switch to kobject_init_and_add() and check the return code.
Make lkpifill_pci_dev() return the error and deal in the callers
with a possible error accordingly.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable