LinuxKPI: pci: deal with kobject_add() being able to fail
ClosedPublic
Actions

Authored by bz on Sun, May 4, 10:04 PM.

Details

Reviewers

Group Reviewers

Commits

rG96ee4e56125d: LinuxKPI: pci: deal with kobject_add() being able to fail
rG96e86aa6faa6: LinuxKPI: pci: deal with kobject_add() being able to fail

Summary

lkpifill_pci_dev() uses a sequene of kobject_init/set_name/add.
The problem is that kobject_add could fail.

Move the entire logic to the beginning of the function,
switch to kobject_init_and_add() and check the return code.
Make lkpifill_pci_dev() return the error and deal in the callers
with a possible error accordingly.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Sun, May 4, 10:04 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSun, May 4, 10:04 PM

bz requested review of this revision.Sun, May 4, 10:04 PM

Harbormaster completed remote builds in B63878: Diff 154810.Sun, May 4, 10:04 PM

dumbbell accepted this revision.Thu, May 8, 9:55 AM

This revision is now accepted and ready to land.Thu, May 8, 9:55 AM

Closed by commit rG96e86aa6faa6: LinuxKPI: pci: deal with kobject_add() being able to fail (authored by bz). · Explain WhyFri, May 9, 7:46 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG96e86aa6faa6: LinuxKPI: pci: deal with kobject_add() being able to fail.

bz added a commit: rG96ee4e56125d: LinuxKPI: pci: deal with kobject_add() being able to fail.Thu, May 15, 9:53 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_pci.c

29 lines

Diff 155219

View Options

sys/compat/linuxkpi/common/src/linux_pci.c

LinuxKPI: pci: deal with kobject_add() being able to failClosedPublicActions