ftp/curl: Fix build with --with-gssapi and --disable-ftp

[michaelo]

Summary

Approved by: jrm (mentor), otis (mentor), sunport (maintainer)
Upstream PR: https://github.com/curl/curl/issues/16925

[michaelo]

Build error in poudriere:

--- curl ---
libtool: link: cc -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -Qunused-arguments -Werror-implicit-function-declaration -Wl,-rpath -Wl,/usr/local/lib:/usr/lib -fstack-protector-strong -o .libs/curl curl-slist_wc.o curl-terminal.o curl-tool_bname.o curl-tool_cb_dbg.o curl-tool_cb_hdr.o curl-tool_cb_prg.o curl-tool_cb_rea.o curl-tool_cb_see.o curl-tool_cb_soc.o curl-tool_cb_wrt.o curl-tool_cfgable.o curl-tool_dirhie.o curl-tool_doswin.o curl-tool_easysrc.o curl-tool_filetime.o curl-tool_findfile.o curl-tool_formparse.o curl-tool_getparam.o curl-tool_getpass.o curl-tool_help.o curl-tool_helpers.o curl-tool_ipfs.o curl-tool_libinfo.o curl-tool_listhelp.o curl-tool_main.o curl-tool_msgs.o curl-tool_operate.o curl-tool_operhlp.o curl-tool_paramhlp.o curl-tool_parsecfg.o curl-tool_progress.o curl-tool_setopt.o curl-tool_sleep.o curl-tool_ssls.o curl-tool_stderr.o curl-tool_strdup.o curl-tool_urlglob.o curl-tool_util.o curl-tool_vms.o curl-tool_writeout.o curl-tool_writeout_json.o curl-tool_xattr.o curl-var.o ../lib/curl-base64.o ../lib/curl-curl_multibyte.o ../lib/curl-dynbuf.o ../lib/curl-nonblock.o ../lib/curl-strparse.o ../lib/curl-strcase.o ../lib/curl-timediff.o ../lib/curl-timeval.o ../lib/curl-version_win32.o ../lib/curl-warnless.o curl-tool_hugehelp.o curl-tool_ca_embed.o  -L/usr/local/lib -L/usr/lib ../lib/.libs/libcurl.so -lnghttp2 -lssl -lcrypto -lk5crypto -lcom_err -lz -lkrb5 -lgssapi_krb5 -pthread -Wl,-rpath -Wl,/usr/local/lib
ld: error: undefined reference due to --no-allow-shlib-undefined: Curl_sec_conn_destroy
>>> referenced by ../lib/.libs/libcurl.so

ld: error: undefined reference due to --no-allow-shlib-undefined: Curl_sec_conn_init
>>> referenced by ../lib/.libs/libcurl.so
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [curl] Error code 1

make[1]: stopped in /wrkdirs/usr/ports/ftp/curl/work/curl-8.13.0/src
--- libcurltool.la ---

[otis]

To me LGTM.

[michaelo]

Waiting for port maintainer's consent.

[jrm]

This fixes a build problem, so you can commit with implicit maintainer approval.

[jrm]

In D50052#1141939, @jrm wrote:

This fixes a build problem, so you can commit with implicit maintainer approval.

I see some people use implicit portgmr approval when fixing builds. For example, 7d61294c3546ec94549b2f75e14c2e3c2ca09791. I'm not sure whether this is documented anywhere.

[michaelo]

In D50052#1141942, @jrm wrote:

In D50052#1141939, @jrm wrote:

This fixes a build problem, so you can commit with implicit maintainer approval.

I see some people use implicit portgmr approval when fixing builds. For example, 7d61294c3546ec94549b2f75e14c2e3c2ca09791. I'm not sure whether this is documented anywhere.

Just checked, it does actually: https://docs.freebsd.org/en/articles/committers-guide/#ports-qa-misc-blanket-approval, but fails to say what one should add to "Approved by:". Obviously docs need improvement.