Page MenuHomeFreeBSD
Differential D49917

agp: use iterators to speed up lookups
ClosedPublic
Actions

Authored by dougm on Apr 19 2025, 5:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 3:48 PM
Unknown Object (File)
Thu, Oct 16, 9:15 AM
Unknown Object (File)
Wed, Oct 15, 11:31 PM
Unknown Object (File)
Wed, Oct 15, 5:08 AM
Unknown Object (File)
Wed, Oct 8, 10:11 AM
Unknown Object (File)
Sep 11 2025, 6:53 AM
Unknown Object (File)
Aug 29 2025, 7:21 AM
Unknown Object (File)
Aug 9 2025, 4:45 AM
View All 46 Files
Subscribers
alc
imp

Details

Reviewers
kib
Commits
rGe1f3f15192c1: agp: use iterators to speed up lookups
Summary

agp_generic_bind_memory and agp_generic_unbind_memory do pctrie lookups for ranges of consecutive pages. Use iterators to improved the expected performance of those searches.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Apr 19 2025, 5:55 PM
dougm created this revision.
kib accepted this revision.Apr 19 2025, 10:24 PM
This revision is now accepted and ready to land.Apr 19 2025, 10:24 PM
Closed by commit rGe1f3f15192c1: agp: use iterators to speed up lookups (authored by dougm). · Explain WhyApr 19 2025, 10:33 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGe1f3f15192c1: agp: use iterators to speed up lookups.
Herald added a subscriber: imp. · View Herald TranscriptApr 19 2025, 10:33 PM
alc added a subscriber: alc.Apr 26 2025, 7:25 PM
alc added inline comments.
sys/dev/agp/agp.c
614

This reset is unnecessary. The object lock is held continuously to the next use of the iterator.

Revision Contents
Changeset List

PathSize
sys/
dev/
agp/
13 lines

Diff 153943

View Options

sys/dev/agp/agp.c

Loading...