Page MenuHomeFreeBSD

[PATCH] net/jose: Fix compilation on 13.5 and 14.x
ClosedPublic

Authored by kiwi on Apr 17 2025, 9:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 24, 8:15 AM
Unknown Object (File)
Sep 13 2025, 11:26 AM
Unknown Object (File)
Sep 13 2025, 10:16 AM
Unknown Object (File)
Sep 11 2025, 5:20 PM
Unknown Object (File)
Sep 11 2025, 12:58 AM
Unknown Object (File)
Sep 7 2025, 3:34 PM
Unknown Object (File)
Aug 25 2025, 2:50 PM
Unknown Object (File)
Aug 9 2025, 5:57 AM
Subscribers

Details

Summary
net/jose: Fix compilation on 13.5 and 14.x

This patch removes a check that was previously added on PR 277905
by adding a -export-symbols-regex=^jose_.* flag only on FreeBSD.

The PR 277905 fix has been merged into upstream jose but it seems
that something is still not handled correctly on FreeBSD 13.5 and
14.x branches.

This workaround is just temporary to make the port build again
on 13.5 and 14. I will work with upstream to find the right
long-term fix.

PR:             284417, 277905
Reported by:    Alexey <ucu8u1b-ol@avksrv.org>
Approved by:    0mp (mentor)
Sponsored by:   Klara, Inc.
Test Plan

Tested with serveral poudriere build:

  • 13.3-RELEASE
  • 13.4-RELEASE
  • 13.5-RELEASE
  • 14.2-RELEASE

And local test with net/jose user

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kiwi requested review of this revision.Apr 17 2025, 9:49 AM
kiwi created this revision.
kiwi edited the summary of this revision. (Show Details)

PR number should be 284417.

You are right... a 2 has comming from nowhere

This revision is now accepted and ready to land.Apr 17 2025, 4:06 PM
diizzy requested changes to this revision.Apr 17 2025, 4:24 PM
diizzy added a subscriber: diizzy.

This should be upstreamed and pull from there.
Commit message is poor at best, explain what it fixes.

This revision now requires changes to proceed.Apr 17 2025, 4:24 PM

This should be upstreamed and pull from there.
Commit message is poor at best, explain what it fixes.

You are right, I have updated the commit message to reflect the issue and I will work with upstream to find a better fix that this ugly patch.

This revision was not accepted when it landed; it landed in state Needs Revision.May 16 2025, 1:23 PM
This revision was automatically updated to reflect the committed changes.