Add PAM support for lock(1). This makes "lock -p" actually useful.

[des]

usr.bin/lock/lock.c

74 ↗

(On Diff #12417)

PAM isn't optional in FreeBSD, so there is no need for USE_PAM.

144 ↗

(On Diff #12417)

PAM is not optional; S/KEY aka OPIE is only supported through PAM.

172–191 ↗

(On Diff #12417)

You should probably replace this with getpass() or even openpam_ttyconv() (you can either call it directly or use pam_prompt() if you have a PAM handle, which you can get even if you don't intend to use PAM to unlock).

258–263 ↗

(On Diff #12417)

As mentioned earlier, you can use getpass() or openpam_ttyconv() / pam_prompt() here instead of fgets().

[trasz]

Get rid of USE_PAM and do some other cleanups.

[trasz]

usr.bin/lock/lock.c

172–191 ↗

(On Diff #12417)

It's a good idea, but IMHO it's orthogonal to adding PAM support. I'd prefer to do that in a separate patch, especially that it might change the behaviour slightly (getpass() reads from console, the code above reads from standard input; no idea if it could make a practical difference).

[des]

usr.bin/lock/lock.c

246 ↗

(On Diff #32797)

Please use an explicit comparison to 0 as strcmp() is not a predicate.

[trasz]

usr.bin/lock/lock.c

246 ↗

(On Diff #32797)

Erm, but that's existing code - I'm only removing the "else" clause.

[trasz]

Regenerate; upstream changed a bit.

[des]

Approved, but I hope you also find the time to make the other modifications I suggested in a later commit.

[trasz]

Make tinderbox happy.