Differential D49537

[PATCH] net/akhq: misc fix
ClosedPublic
Actions

Authored by kiwi on Mar 27 2025, 4:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 16, 1:38 PM

	Unknown Object (File)
	Wed, Apr 23, 3:31 PM

	Unknown Object (File)
	Tue, Apr 22, 2:24 AM

	Unknown Object (File)
	Mon, Apr 21, 7:26 AM

	Unknown Object (File)
	Sun, Apr 20, 10:32 PM

	Unknown Object (File)
	Sun, Apr 20, 2:28 AM

	Unknown Object (File)
	Sun, Apr 20, 1:03 AM

	Unknown Object (File)
	Apr 17 2025, 4:16 AM

View All 30 Files

Subscribers

None

Details

Reviewers

0mp
kevans
admin_hackacad.net

Commits

R11:7820c0a420e4: net/akhq: misc fix

Summary

net/akhq: misc fix

- Fix handling of sample file
- Fix PREFIX vs LOCALBASE in the .in file
- Fix NO_EXTRACT and CONFIG_FILES that are not needed anymore

Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor)
Approved by:    kevans
Reported by:    diizzy

Test Plan

Poudriere build is ok on 14.2-RELEASE
portclippy and portlink are ok

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kiwi requested review of this revision.Mar 27 2025, 4:29 PM

kiwi created this revision.

0mp added inline comments.Mar 27 2025, 7:47 PM

net/akhq/files/akhq.in
19	This one should stay LOCALBASE, because it is not a file installed by akhq.

Once that little typo is fixed, the commit is ready to land.

Approved by: 0mp (mentor)

LGTM
Maintainer feedback +

In D49537#1129478, @0mp wrote:

Once that little typo is fixed, the commit is ready to land.

Approved by: 0mp (mentor)

This revision is now accepted and ready to land.Mar 27 2025, 8:10 PM

Fixed typo detected by @0mp

This revision now requires review to proceed.Mar 28 2025, 12:03 PM

kiwi marked an inline comment as done.Mar 28 2025, 12:04 PM

kiwi added inline comments.

net/akhq/files/akhq.in
19	Thanks :)

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2025, 4:35 PM

Closed by commit R11:7820c0a420e4: net/akhq: misc fix (authored by kiwi). · Explain Why

This revision was automatically updated to reflect the committed changes.

kiwi marked an inline comment as done.

kiwi added a commit: R11:7820c0a420e4: net/akhq: misc fix.

Revision Contents
Changeset List

Path

Size

net/

akhq/

9 lines

files/

4 lines

Diff 152796

net/akhq/Makefile

Loading...

net/akhq/files/akhq.in

Loading...