Page MenuHomeFreeBSD

proc: Disallow re-enabling of process itimers during exit
ClosedPublic

Authored by markj on Mar 27 2025, 10:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 5:20 PM
Unknown Object (File)
Sun, Sep 28, 7:11 AM
Unknown Object (File)
Fri, Sep 26, 11:18 AM
Unknown Object (File)
Fri, Sep 26, 11:13 AM
Unknown Object (File)
Sun, Sep 21, 6:42 AM
Unknown Object (File)
Sep 10 2025, 6:51 AM
Unknown Object (File)
Sep 10 2025, 3:02 AM
Unknown Object (File)
Sep 10 2025, 2:52 AM
Subscribers

Details

Summary

During process exit, it's possible for the exiting thread to send a
signal to its process, via killjobc(). This happens after the itimer is
drained. If itimers are stopped, i.e., P2_ITSTOPPED is set, then
itimer_proc_continue() will resume the callout after it has been
drained.

Fix the problem by simply clearing P2_ITSTOPPED as part of the drain.
Then, a signal received after that point will not re-enable the callout.

Reported by: syzkaller

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is fine.
But also I suggest to add the check for P_WEXIT/P_KILLED before re-arming the itimer callouts.

This revision is now accepted and ready to land.Mar 27 2025, 4:59 PM

Check for P_WEXIT in realitexpire_reset_callout() too.

This revision now requires review to proceed.Mar 28 2025, 8:54 AM
This revision is now accepted and ready to land.Mar 28 2025, 3:22 PM