Page MenuHomeFreeBSD

linuxkpi: Add `seq_hex_dump()`
AbandonedPublic

Authored by dumbbell on Mar 15 2025, 11:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 21 2025, 2:58 AM
Unknown Object (File)
Sep 19 2025, 12:41 PM
Unknown Object (File)
Sep 18 2025, 3:13 PM
Unknown Object (File)
Sep 16 2025, 8:10 AM
Unknown Object (File)
Sep 13 2025, 4:06 AM
Unknown Object (File)
Sep 11 2025, 10:22 PM
Unknown Object (File)
Sep 11 2025, 5:18 PM
Unknown Object (File)
Sep 2 2025, 9:37 PM
Subscribers

Details

Reviewers
bz
Group Reviewers
linuxkpi
Summary

It is a copy of print_hex_dump() but uses a struct sbuf as the destination.

The amdgpu DRM driver started to use it in Linux 6.8.

This is part of the update of DRM drivers to Linux 6.8.

Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Alternatively I quickly hacked this up -- I don't know which one would be preferable: https://reviews.freebsd.org/D49637

sys/compat/linuxkpi/common/src/linux_seq_file.c
317

For all of these printfs with prefix_str you need an extra %s and check (prefix_str != NULL) ? " " : "" to get the extra space after

320

I think the original implementation of print_hex_dump() got switched to #tx on purpose

bz requested changes to this revision.Apr 2 2025, 6:15 PM
This revision now requires changes to proceed.Apr 2 2025, 6:15 PM