Page MenuHomeFreeBSD
Differential D49017

vm_object: drop pointless assignment
ClosedPublic
Actions

Authored by dougm on Feb 14 2025, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 31, 6:19 AM
Unknown Object (File)
Fri, Oct 31, 1:02 AM
Unknown Object (File)
Fri, Oct 31, 1:02 AM
Unknown Object (File)
Fri, Oct 31, 1:02 AM
Unknown Object (File)
Thu, Oct 30, 8:03 PM
Unknown Object (File)
Wed, Oct 29, 5:09 PM
Unknown Object (File)
Wed, Oct 29, 5:09 PM
Unknown Object (File)
Wed, Oct 29, 5:09 PM
View All 54 Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rGfa462b8b8ebc: vm_object: drop pointless assignment
Summary

An assignment in collapse_scan() has become useless because, on every path, another assignment to that variable overrides it before that variable is read.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Feb 14 2025, 10:38 PM
dougm created this revision.
markj accepted this revision.Feb 15 2025, 3:55 PM
This revision is now accepted and ready to land.Feb 15 2025, 3:55 PM
alc accepted this revision.Feb 15 2025, 5:53 PM
alc added inline comments.Feb 15 2025, 5:57 PM
sys/vm/vm_object.c
1705–1706

You can also defer this assignment.

Closed by commit rGfa462b8b8ebc: vm_object: drop pointless assignment (authored by dougm). · Explain WhyFeb 15 2025, 6:11 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGfa462b8b8ebc: vm_object: drop pointless assignment.
Herald added a subscriber: imp. · View Herald TranscriptFeb 15 2025, 6:11 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
7 lines

Diff 151081

View Options

sys/vm/vm_object.c

Loading...