Page MenuHomeFreeBSD

Make crypt(3) thread-safe by utilizing thread-local storage.
Needs ReviewPublic

Authored by delphij on Feb 5 2025, 6:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 5:51 AM
Unknown Object (File)
Sep 15 2025, 2:15 PM
Unknown Object (File)
Sep 13 2025, 11:53 PM
Unknown Object (File)
Sep 9 2025, 4:21 AM
Unknown Object (File)
Aug 23 2025, 10:35 PM
Unknown Object (File)
Aug 15 2025, 4:39 PM
Unknown Object (File)
Jul 28 2025, 2:46 PM
Unknown Object (File)
Jul 27 2025, 2:34 AM
Subscribers
None

Details

Reviewers
emaste
imp
jrtc27
Summary

The crypt(3) interface is a wrapper around crypt_r(3) where a global
static storage is passed as data. Modernize the interface by
passing a thread-local storage instead so it is thread-safe.

Test Plan

kyua test lib/libcrypt

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 62267
Build 59151: arc lint + arc unit

Event Timeline

delphij created this revision.

It's still not thread-safe if you pass the return value to another thread, but perhaps that's outside the scope