Page MenuHomeFreeBSD

Make crypt(3) thread-safe by utilizing thread-local storage.
Needs ReviewPublic

Authored by delphij on Feb 5 2025, 6:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 3, 1:00 PM
Unknown Object (File)
Sun, May 3, 7:15 AM
Unknown Object (File)
Wed, Apr 29, 5:20 AM
Unknown Object (File)
Wed, Apr 29, 12:45 AM
Unknown Object (File)
Sun, Apr 19, 1:45 AM
Unknown Object (File)
Apr 14 2026, 7:03 AM
Unknown Object (File)
Apr 14 2026, 12:08 AM
Unknown Object (File)
Apr 5 2026, 10:26 AM
Subscribers
None

Details

Reviewers
emaste
imp
jrtc27
Summary

The crypt(3) interface is a wrapper around crypt_r(3) where a global
static storage is passed as data. Modernize the interface by
passing a thread-local storage instead so it is thread-safe.

Test Plan

kyua test lib/libcrypt

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 62267
Build 59151: arc lint + arc unit

Event Timeline

delphij created this revision.

It's still not thread-safe if you pass the return value to another thread, but perhaps that's outside the scope