Remove USE_PYTHON dependency for lang/python27 and cleanups
ClosedPublic
Actions

Authored by mva on Jul 26 2014, 1:18 PM.

Details

Reviewers

koobs
bapt

Group Reviewers

Python

Summary

This removes the USE_PYTHON depdendency for lang/python27 to allow
bsd.python.mk to be transformed into a Uses file without any additional glue
code in Mk/

Additionally, the static/shared build has been replaced by the build process
used for lang/python34, which greatly simplifies the build.

Other changes include:

Removal of PTH option (ports/191888)
Removal of bin/smtpd - it's inconsistent with the rest
Removal of FPECTL option - it's inconsistent with the rest
New DEBUG option
Backport of a distutils.build_scripts.copy_scripts() return value for copying scripts with a major.minor version on installation

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mva updated this revision to Diff 843.Jul 26 2014, 1:18 PM

mva retitled this revision from to Remove USE_PYTHON dependency for lang/python27 and cleanups.

mva updated this object.

mva edited the test plan for this revision. (Show Details)

mva added reviewers: Python, bapt.

mva added a parent revision: D399: Convert bsd.python.mk to USES=python.Jul 26 2014, 1:19 PM

koobs requested changes to this revision.Jul 26 2014, 1:28 PM

koobs added a reviewer: koobs.

koobs added a subscriber: koobs.

koobs added inline comments.

lang/python27/Makefile
17	"cpe" up front (sort by alpha)
63	Missing last char of "no" for ac_cv_posix_semaphores_enabled= value
74	Are all these bits below (X86_ONLY, 32BIT_ONLY, etc) still needed?
lang/python27/files/patch-setup.py
99	How come we're keeping this?

This revision now requires changes to proceed.Jul 26 2014, 1:28 PM

mva added inline comments.Jul 26 2014, 1:46 PM

lang/python27/files/patch-setup.py
99	Because it's an upstream default.

mva added inline comments.Jul 26 2014, 1:47 PM

lang/python27/Makefile
74	Possibly. I did not test it on the archs.

Fixed USES order (cpe)
Fixed missing o in "no" for SEM option

Prefer to see the special ARCH bits disappear, but happy to defer it until after these land.

This revision is now accepted and ready to land.Jul 27 2014, 4:05 AM

Fix plist, if DEBUG option is enabled
Add some inline comments for the patches

koobs added inline comments.Jul 27 2014, 11:33 AM

lang/python27/Makefile
128	Did you mean to remove this but keep the rest of the NIS bits?

mva added inline comments.Jul 27 2014, 11:52 AM

lang/python27/Makefile
128	Yes. We should not set WITHOUT_NIS in the port, since it is a global switch. What was done here looks like a weird workaround to test for WITHOUT_NIS only later on, which I changed.