Remove USE_PYTHON dependency for lang/python33, simplify build
ClosedPublic
Actions

Authored by mva on Jul 15 2014, 6:43 AM.

Details

Reviewers

koobs
bapt

Group Reviewers

Python

Summary

This removes the USE_PYTHON depdendency for lang/python33 to allow
bsd.python.mk to be transformed into a Uses file without any additional glue
code in Mk/

Additionally, the static/shared build has been replaced by the build process
used for lang/python34, which greatly simplifies the build.

PORTDATA and PORTEXAMPLES have been removed (for now).

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mva updated this revision to Diff 709.Jul 15 2014, 6:43 AM

mva retitled this revision from to Remove USE_PYTHON dependency for lang/python33, simplify build.

mva updated this object.

mva edited the test plan for this revision. (Show Details)

mva added reviewers: Python, bapt.

That looks very good thank you!

This revision is now accepted and ready to land.Jul 15 2014, 7:11 AM

koobs requested changes to this revision.Jul 15 2014, 7:17 AM

koobs added a reviewer: koobs.

koobs added a subscriber: koobs.

koobs added inline comments.

lang/python33/Makefile
52	You might want to use LIBS here like python27 recently has. Reduce diffs too
60	Does 33 have TSC ?
79	Can this go upstream (issue?)
104	buildbottest is somewhat better, and is also what lang/python27 uses. reduces diffs
lang/python33/files/patch-setup.py
8	Dont want to copy in the python34 functionality for this?

This revision now requires changes to proceed.Jul 15 2014, 7:17 AM

mva added inline comments.Jul 15 2014, 8:36 AM

lang/python33/Makefile
52	Agreed, we should bring this to lang/python32 lang/python34 too.
60	Yes
79	Didn't you create one for lang/python34? The Makefile is basically a plain copy of lang/python34
104	Agreed. We should bring this to lang/python32 lang/python34 too
lang/python33/files/patch-setup.py
8	The python34 patch is far to complex for those three.