fdisk: Remove support for vinum volumes
ClosedPublic
Actions

Authored by jhb on Jan 20 2025, 7:46 PM.

Details

Reviewers

emaste
imp

Commits

rG2b12e6676a00: fdisk: Remove support for vinum volumes

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61810
Build 58694: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 20 2025, 7:46 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 20 2025, 7:46 PM

jhb requested review of this revision.Jan 20 2025, 7:46 PM

Harbormaster completed remote builds in B61810: Diff 149580.Jan 20 2025, 7:46 PM

jhb added a parent revision: D48536: ccdconfig.8: Refer to graid(8) and zfs(8) instead of gvinum(8).Jan 20 2025, 7:46 PM

jhb added a child revision: D48538: ffsinfo: Remove support for vinum volumes.

Though we are deleting this...

This revision is now accepted and ready to land.Jan 20 2025, 7:50 PM

Fine with me, but it can happen after the removal rather than as a dependency of the removal, IMO.

In D48537#1107487, @imp wrote:

Though we are deleting this...

Maybe? I'm just focused on removing vinum support and fdisk is still in the tree currently.

Maybe? I'm just focused on removing vinum support and fdisk is still in the tree currently.

Indeed; as of rGb8c19fd719945 the man page states This command is obsolete. Users are advised to use gpart(8) instead. and as of 86e66321bb18 fdisk prints a deprecation notice when run.

I still think it's reasonable for these sort of changes to go in after the actual removal.

Closed by commit rG2b12e6676a00: fdisk: Remove support for vinum volumes (authored by jhb). · Explain WhyJan 23 2025, 4:21 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG2b12e6676a00: fdisk: Remove support for vinum volumes.

Revision Contents
Changeset List

Path

Size

sbin/

fdisk/

fdisk.c

3 lines

Diff 149580

View Options

fdisk: Remove support for vinum volumesClosedPublicActions