Page MenuHomeFreeBSD

LinuxKPI 802.11 / rtw88: make packets flow again
Needs ReviewPublic

Authored by bz on Fri, Dec 20, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 4:46 PM
Unknown Object (File)
Sun, Dec 29, 1:29 PM
Unknown Object (File)
Sat, Dec 28, 2:36 PM
Unknown Object (File)
Fri, Dec 27, 8:29 PM
Unknown Object (File)
Fri, Dec 27, 7:34 PM
Unknown Object (File)
Fri, Dec 27, 7:20 PM
Unknown Object (File)
Fri, Dec 27, 5:10 PM
Unknown Object (File)
Fri, Dec 27, 12:08 PM
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

In 886653492945f we added checks for packets to only go out if the
station is known to the firmware (amongst others) as there are
implications in drivers.
Unfortunately rtw88 does not support the mac80211 (*sta_state)() KPI
but only the fallback (*sta_add/remove)() in which case the station is
only added to firmware when going from AUTH to ASSOC. That means we
had no chance to get ever authenticated anymore.

The problem has existed since June in main and stable/14 but only now
was noticed in December which makes me wonder.

I am not sure what implications the missing checks have on all the other
drivers using (*sta_state)() as I hav enot done the full due-diiigens
on that yet. For the moment I want to get the patch out so that rtw88
users can test (or auth/assoc) and use rtw88 again.

PR: 283142
Fixes: 886653492945f (make sure we can send DISASSOC or DEAUTH frames)
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61283
Build 58167: arc lint + arc unit